HomeWildfire Games

Split VictoryDuration in RelicDuration and WonderDuration

Description

Split VictoryDuration in RelicDuration and WonderDuration

As proposed by leper in rP19345
refs #4014

Reviewed By: elexis
Differential Revision: https://code.wildfiregames.com/D874

Details

Committed
bbSep 6 2017, 10:44 AM
Reviewer
elexis
Differential Revision
D874: Split VictoryDuration
Parents
rP20121: [i18n] Updated POT and PO files.
Branches
Unknown
Tags
Unknown
Build Status
Buildable 3038
Build 5261: Post-Commit BuildJenkins

Event Timeline

bb added inline comments.Sep 6 2017, 3:18 PM
/ps/trunk/binaries/data/mods/public/simulation/helpers/Setup.js
48โ€“51

Style broken here, no need for a concern since the lines will be changed anyway when implementing #4014 fully

elexis added a subscriber: elexis.Sep 6 2017, 9:01 PM
elexis added inline comments.
/ps/trunk/binaries/data/mods/public/simulation/helpers/Setup.js
48โ€“51

What broken style?

elexis added inline comments.Sep 6 2017, 9:06 PM
/ps/trunk/binaries/data/mods/public/simulation/helpers/Setup.js
48โ€“51

Ah, you mean the duplicate if-statement