HomeWildfire Games
Diffusion 0 A.D. Public Repository rP20321

Add id for IQ stanzas
AuditedrP20321
Actions

Description

Add id for IQ stanzas

Patch by: Dunedan
Differential Revision: https://code.wildfiregames.com/D899

Details

Auditors
Itms
Committed
ImarokOct 21 2017, 4:11 PM
Differential Revision
D899: Add id for IQ stanzas
Parents
rP20320: Unify trade gain computation between simulation and ai
Branches
Unknown
Tags
Unknown
Build Status
Buildable 3426
Build 5933: Trigger Windows Autobuild
Build 5932: Post-Commit BuildJenkins

Event Timeline

Imarok committed rP20321: Add id for IQ stanzas.Oct 21 2017, 4:11 PM
Harbormaster completed building B3426: rP20321: Add id for IQ stanzas.Oct 21 2017, 5:01 PM
elexis awarded a token.Oct 21 2017, 5:26 PM
elexis raised a concern with this commit.Oct 22 2017, 3:03 PM
elexis added a subscriber: elexis.

Just for reference https://wildfiregames.com/forum/index.php?/topic/22964-svn20325-compile-error/

This commit now has outstanding concerns.Oct 22 2017, 3:03 PM
elexis removed an auditor: elexis.Oct 22 2017, 6:47 PM

Just need a new precompiled DLL

This commit no longer requires audit.Oct 22 2017, 6:47 PM
Imarok mentioned this in rP20340: Update the bundled gloox wrapper for Windows..Oct 24 2017, 4:56 PM
Itms raised a concern with this commit.Mar 11 2018, 6:34 PM
Itms added a subscriber: Itms.

Using std::string defeats the purpose of the glooxwrapper. It does not create bugs, unless we have the same variety of compilers we had when the lobby was introduced, which might happen at some point.

/ps/trunk/source/lobby/glooxwrapper/glooxwrapper.cpp
349

This should be

const glooxwrapper::string glooxwrapper::Client::getID() const

(with the extra const-correctness)

/ps/trunk/source/lobby/glooxwrapper/glooxwrapper.h
397
const string getID() const;
This commit now has outstanding concerns.Mar 11 2018, 6:34 PM
Imarok mentioned this in rP21508: Address concerns of rP20321.Mar 11 2018, 7:32 PM
Itms accepted this commit.Apr 13 2018, 5:39 PM

Forgot to accept that.

All concerns with this commit have now been addressed.Apr 13 2018, 5:39 PM

Changes (4)

PathSize
ps/
trunk/
binaries/
data/
mods/
public/
gui/
credits/
texts/
source/
lobby/
glooxwrapper/

rP20321

View Options

ps/trunk/binaries/data/mods/public/gui/credits/texts/programming.json

Loading...
View Options

ps/trunk/source/lobby/XmppClient.cpp

Loading...
View Options

ps/trunk/source/lobby/glooxwrapper/glooxwrapper.cpp

Loading...
View Options

ps/trunk/source/lobby/glooxwrapper/glooxwrapper.h

Loading...
Wildfire Games ยท Phabricator