Diffusion 0 A.D. Public Repository rP20357

Move SimpleObject and RandomObject from placers.js to a new file, because they…
rP20357
Actions

Tags

None

Subscribers

None

Description

Move SimpleObject and RandomObject from placers.js to a new file, because they aren't Placers, refs #4804.
Define what an Object is, refs #4831.
Remove RandomObject duplication from rP9388 by just calling the SimpleObject with a random template, refs #4805.

Remove the tautologous (!fail) check and replace needless multilevel fail-check nesting with two && operators.
Move default parameters from the function body to the function header and rename resultObjs to entities.
Throw errors instead of printing something if min > max.

Details

Committed

Oct 27 2017, 1:51 AM

Parents

rP20356: Fix lineendings of new files and the ones in source/ that didn't receive the…

Branches

Unknown

Tags

Unknown

Build Status

Buildable 3500
Build 6062: Post-Commit Build	Jenkins

Event Timeline

elexis committed rP20357: Move SimpleObject and RandomObject from placers.js to a new file, because they….Oct 27 2017, 1:51 AM

elexis mentioned this in rP9388: Tweaks random map appearance and resource placement..Oct 27 2017, 1:53 AM

elexis added inline comments.Oct 27 2017, 1:56 AM

/ps/trunk/binaries/data/mods/public/maps/random/rmgen/placer.js
309	Also deletes this unreferenced something from rP9096.

Harbormaster completed building B3500: rP20357: Move SimpleObject and RandomObject from placers.js to a new file, because they….Oct 27 2017, 2:40 AM

elexis mentioned this in D189: Extending rmgen lib's SimpleGroup's place method to avoid collision of included SimpleObjects.Oct 29 2017, 9:59 PM

elexis mentioned this in rP9096: Implements random map system, fixes #6..Oct 31 2017, 2:55 PM

Changes (2)

Path

Size

ps/

trunk/

binaries/

data/

mods/

public/

maps/

random/

rmgen/

rP20357

ps/trunk/binaries/data/mods/public/maps/random/rmgen/object.js

Loading...

ps/trunk/binaries/data/mods/public/maps/random/rmgen/placer.js

Loading...