HomeWildfire Games

Consistently use utf8 instead of iso-8859-1 encoding in XML files.

Description

Consistently use utf8 instead of iso-8859-1 encoding in XML files.

Differential Revision: https://code.wildfiregames.com/D622
Reviewed By: Dunedan

Details

Committed
elexisOct 29 2017, 6:18 PM
Reviewer
Dunedan
Differential Revision
D622: Use utf8 instead of iso-8859-1 in XML files
Parents
rP20375: [Windows] Automated build.
Branches
Unknown
Tags
Unknown
Build Status
Buildable 3543
Build 6147: Post-Commit BuildJenkins

Event Timeline

I don't know why but it break the checkrefs script on my config.

Couldn't open encmap utf8.enc:
No such file or directory
at /usr/lib/x86_64-linux-gnu/perl5/5.26/XML/Parser.pm line 187.
XML::Simple called at checkrefs.pl line 351.

Perhaps simply due to not sufficient installation on my side.

Or perhaps utf8 should be utf-8.

elexis added a comment.Nov 2 2017, 6:56 PM

Or perhaps utf8 should be utf-8.

Given that there are 5064 matches of encoding="utf-8" but only 29 with encoding="utf8" and the commit changing 29 occurrences to utf8: Fail -_-

elexis added a comment.Nov 2 2017, 7:00 PM

(Looks like it could become optional (no encoding means no typos in the encoding): http://xmlwriter.net/xml_guide/xml_declaration.shtml but not going to change 5k files for that. Also having the encoding fixed is good practice as documents that can be interpreted with numerous encodings easily break)

(as I needed it locally, I uploaded it at D1005)