HomeWildfire Games

Migrate to premake5, fixes #3729.
Needs VerificationrP20381

Description

Migrate to premake5, fixes #3729.
Make pyrogenesis and tests depend on Collada, fixes #404.

This commit includes custom modules for CxxTest and pkg-config support that can be improved upon in the future. It also includes all necessary changes to the build scripts, but the new premake5 features are not fully exploited yet.

With this change, premake5 becomes the default, but CI scripts on Unix will continue using premake4 for a while, in order to avoid regressions.

Includes code by zsol.
Reviewed by: wraitii, leper
Differential Revision: https://code.wildfiregames.com/D72

Details

Auditors
leper
wraitii
Committed
ItmsOct 30 2017, 2:52 PM
Reviewer
wraitii
Differential Revision
D72: Migrate to premake5
Parents
rP20380: [i18n] Updated POT and PO files.
Branches
Unknown
Tags
Unknown
Build Status
Buildable 3551
Build 6162: Trigger Windows Autobuild
Build 6161: Post-Commit BuildJenkins

Event Timeline

Not that I actually tested this, or formally accepted that revision.

Not that I actually tested this, or formally accepted that revision.

Yes indeed, but you gave a lot of advice on how to improve the code. @elexis is right, we must formalize how to write commit messages so we can thank people without putting a responsibility on them 🙂 Note that Phabricator links only @wraitii as the reviewer, since he's the first in the message.

wraitii raised a concern with this commit.Nov 4 2017, 2:37 PM

Erf, I totally did not try building the tests and it turns out xCode doesn't support custom build commands so compiling the tests with xCode fails.

I've opened an issue on their GitHub as that's apparently the subject of an old PR so I suspect it'd be somewhat easy to fix (but I have to say I tried applying the patch and it didn't seem to change something).

TBH it's not a huge issue because the make version works correctly, but yeah. Sorry about that.

This commit now has outstanding concerns.Nov 4 2017, 2:37 PM
leper raised a concern with this commit.Nov 25 2017, 7:45 AM
leper added inline comments.
/ps/trunk/build/premake/cxxtest/cxxtest.lua
33

Indeed, it also seems to be the reason why non-pch builds are broken (at least for building tests).

Itms marked an inline comment as done.Nov 26 2017, 12:30 PM

D1068

@wraitii I don't think the patch fixes your issue with xcode, which is upstream, but if you can test that's great.

Itms requested verification of this commit.Feb 9 2018, 2:17 PM
This commit now requires verification by auditors.Feb 9 2018, 2:17 PM
Stan added subscribers: Angen, Stan.Mar 9 2019, 11:15 AM

IIRC @Angen was the first to report that this commit sets Collada as the default project because you removed the

if _OPTIONS["collada"] then
	setup_collada_projects()
end

Else it would start the test project.