HomeWildfire Games

Carthaginian range, workshop, elephant stable, mauryan stable, babylonian…
AuditedrP20427

Description

Carthaginian range, workshop, elephant stable, mauryan stable, babylonian defense tower

Details

Event Timeline

temple added a subscriber: temple.Nov 9 2017, 7:34 PM

Cool stuff as usual.

When I tried the Carthage elephant stables the first time, I got this error:

ERROR: RelaxNGValidator: Validation error: (null):0: Extra element props in interleave
ERROR: RelaxNGValidator: Validation error: art/actors/structures/carthaginians/stable_elephant.xml:7: Element variant failed to validate content
ERROR: RelaxNGValidator: Validation error: art/actors/structures/carthaginians/stable_elephant.xml:5: Element group has extra content: variant
ERROR: RelaxNGValidator: Validation error: (null):0: Extra element group in interleave
ERROR: RelaxNGValidator: Validation error: art/actors/structures/carthaginians/stable_elephant.xml:4: Element actor failed to validate content
ERROR: RelaxNGValidator: Validation failed for '(null)'
ERROR: CXeromyces: failed to validate XML file art/actors/structures/carthaginians/stable_elephant.xml

But after that it was fine. Maybe similar to these errors:
https://trac.wildfiregames.com/ticket/4415
https://wildfiregames.com/forum/index.php?/topic/22950-error-in-building-construction/

Validation error equals ping @Stan (LordGood and Enrique not around on Phabricator)

Stan added inline comments.Nov 10 2017, 2:47 PM
/ps/trunk/binaries/data/mods/public/art/actors/structures/carthaginians/stable_elephant.xml
9

Broken here :)

mimo raised a concern with this commit.Nov 11 2017, 11:32 AM
mimo added a subscriber: mimo.

In rP20398, a new elephant_stables template was created, and all civ ones were changed to inherit from it (resulting in only 10 lines needed in each child templates). The new cart_elephant_stables should follow the same path and not inherit from template_structure_special as done in the patch.

This commit now has outstanding concerns.Nov 11 2017, 11:32 AM
Stan added a comment.Nov 12 2017, 9:26 PM

Am I supposed to fix it before any other commit or, should I ping LordGood or something else ?

Technically only the author of the commit is expected to fix things. Every one elses work on that is voluntary.
So whether you want to ping him and make him aware of the situation, just fix it yourself in a proposed patch, do something else or nothing at all is your choice.
We should just get it done one way or another.

/ps/trunk/binaries/data/mods/public/simulation/templates/structures/maur_stable.xml
12

IIRC we removed these (there are more of those in this commit)

Stan added a comment.Nov 12 2017, 9:37 PM

Okay

/ps/trunk/binaries/data/mods/public/simulation/templates/structures/maur_stable.xml
12

I thought we only removed the history tags

Stan added a subscriber: Nescio.Mar 19 2019, 10:56 AM

@Nescio do you have a patch for it ?

A patch for what to do what?

Stan added a comment.Mar 19 2019, 12:02 PM
In rP20427#24607, @mimo wrote:

In rP20398, a new elephant_stables template was created, and all civ ones were changed to inherit from it (resulting in only 10 lines needed in each child templates). The new cart_elephant_stables should follow the same path and not inherit from template_structure_special as done in the patch.

Fix this ^ if it hasn't been already.

This is the current content of the cart_elephant_stables.xml template:

<?xml version="1.0" encoding="utf-8"?>
<Entity parent="template_structure_military_elephant_stables">
  <Identity>
    <Civ>cart</Civ>
    <SpecificName>Carthaginian Elephant Stables</SpecificName>
  </Identity>
  <VisualActor>
    <Actor>structures/carthaginians/stable_elephant.xml</Actor>
  </VisualActor>
</Entity>
Stan accepted this commit.Mar 19 2019, 12:10 PM

Ah thanks. Fixed by @temple in rP21308

Stan removed an auditor: mimo.Mar 19 2019, 12:11 PM
All concerns with this commit have now been addressed.Mar 19 2019, 12:11 PM