Unify rmgen modifyTilesBasedOnHeight (rP20189) with the HeightPlacer (rP20361).
rP20437
Actions

Description

Unify rmgen modifyTilesBasedOnHeight (rP20189) with the HeightPlacer (rP20361).

Create global constants for the elevation modes and make that Placer more versatile by adding the mode argument.
Improves the performance of these functions by not repeating the mode, createTerrain and getTileClass lookups every tile.
Move the functions to library.js, refs #4804.

Details

Committed

elexis

Nov 10 2017, 11:29 PM

Parents

rP20436: petra: remove an old hack against rabbits as its template was modified some…

Branches

Unknown

Tags

Unknown

Build Status

Buildable 3658
Build 6341: Post-Commit Build	Jenkins

Event Timeline

elexis committed rP20437: Unify rmgen modifyTilesBasedOnHeight (rP20189) with the HeightPlacer (rP20361)..Nov 10 2017, 11:29 PM

elexis added inline comments.Nov 10 2017, 11:34 PM

/ps/trunk/binaries/data/mods/public/maps/random/rmgen/placer_noncentered.js
44	`g_` would seem really out of place to me, since this isn't high-level code but feels as close to the engine as JS gets: createArea( new HeightPlacer(g_Elevation_IncludeMin_IncludeMax, heightRange.min, heighLimits[2]), `g_Something` typically hold high level values. In rmgen we only have `g_Environment`, `g_Map`, `g_MapSettings` and `g_Camera` - all of which contain user values. ALSOALLCAPSCONSTSSEEMUGLY. If someone feels otherwise this can still be easily changed until calls to the `paintSomethingBasedOnHeight` functions replace the magic numbers with the constants.

Harbormaster completed building B3658: rP20437: Unify rmgen modifyTilesBasedOnHeight (rP20189) with the HeightPlacer (rP20361)..Nov 11 2017, 12:20 AM

• leper added a subscriber: • leper.Nov 11 2017, 8:34 PM

• leper added inline comments.

/ps/trunk/binaries/data/mods/public/maps/random/rmgen/placer_noncentered.js
44	And CamelCase_CamelCase_CamelCase looks acceptable? That's worse than g_CamelCase and CAPS_WITH_UNDERSCORES. (Not that I'm actually going to read rms code.)