HomeWildfire Games

Use the rangeManager's subdivisions in the obstruction manager shape tests

Description

Use the rangeManager's subdivisions in the obstruction manager shape tests

Completes an existing TODO. This is a large speedup in some cases for those test functions, particularly the "sunken ship lag" issue.

Patch By: temple

Reviewed By: elexis, mimo, bb, wraitii
Accepted By: bb, wraitii

Trac Tickets: #4713

Differential Revision: https://code.wildfiregames.com/D850

Event Timeline

temple added a subscriber: temple.Nov 11 2017, 5:04 PM

Thanks for committing.

/ps/trunk/source/simulation2/components/CCmpObstructionManager.cpp
742

I guess const here?

763

and here

wraitii added inline comments.Nov 11 2017, 5:28 PM
/ps/trunk/source/simulation2/components/CCmpObstructionManager.cpp
742

Right, missed those. I'll fix it later.

elexis added a subscriber: elexis.Nov 11 2017, 5:29 PM

So I can cheer for having this release blocker ticket fixed (hint) after years of lagging and games where the host disconnected from his localhost server due to this kind of lag? :->

(@temple also feel free to add a performance category in wiki:Alpha23 with an entry of this commit. See also wiki:Alpha22.)

So I can cheer for having this release blocker ticket fixed (hint) after years of lagging and games where the host disconnected from his localhost server due to this kind of lag? :->

Just don't forget about all the other lag :p

Reviewed By: elexis, mimo, bb, wraitii
Accepted By: bb, wraitii

(I observed that the simstate didn't change, but I didn't look at the code)

(@temple also feel free to add a performance category in wiki:Alpha23 with an entry of this commit. See also wiki:Alpha22.)

wiki:GamePerfomance which stopped being updated a while ago. And if someone updates the detailed changelog at least update the whole thing instead of cherry-picking a few revisions making it harder for everone updating later.

It's not making it harder while the "page includes all relevant changes until commit X" entry remains unchanged.

It's not making it harder while the "page includes all relevant changes until commit X" entry remains unchanged.

Until someone updates up to that and there are suddenly two similar but different entries for a single revision.

Sorry, leper. I actually thought about it but 200 updates seemed overwhelming. But maybe I can do some and give you a break (or maybe I'll do them wrong and it'll just make more work for you? :) ). We'll see what happens...

Sorry, leper. I actually thought about it but 200 updates seemed overwhelming. But maybe I can do some and give you a break (or maybe I'll do them wrong and it'll just make more work for you? :) ). We'll see what happens...

Given that I just updated that page since elexis seemed busy, and I wanted to document a few modding related changes, and that has now been done and the next such change ran into some obstacle I don't see me doing that anytime soon.