HomeWildfire Games

Fix an issue with the woman basket having a hole at the bottom. Use a different…

Description

Fix an issue with the woman basket having a hole at the bottom. Use a different actor for gathering, as the previous basket was tilted on the wrong side. Slightly tweak the tip of the basket to look like there is a hole in it. Fix indent in the file.

Details

Committed
StanNov 14 2017, 9:31 PM
Parents
rP20451: Fix some SelectionGroupNames
Branches
Unknown
Tags
Unknown
Build Status
Buildable 3704
Build 6433: Post-Commit BuildJenkins

Event Timeline

Nescio added a subscriber: Nescio.Nov 14 2017, 9:37 PM

“No newline at end of file”
Don't ask me why that's important.

elexis added a subscriber: elexis.Nov 14 2017, 9:54 PM

https://stackoverflow.com/questions/729692/why-should-text-files-end-with-a-newline

(Dunno, but my female_gather_fruit.xml ends with one, is it a phabricator bug?)

Stan added a comment.Nov 14 2017, 9:56 PM

I thought setting EOL to native would fix that kind of issues. My editor just happens to nuke newlines at the end of xml files, and blender apparently does the same when exporting collada.

In rP20452#24820, @Stan wrote:

I thought setting EOL to native would fix that kind of issues. My editor just happens to nuke newlines at the end of xml files, and blender apparently does the same when exporting collada.

The native property only states that files are downloaded with the lineending of the operating system of the user, but doesn't add or remove lineendings.

Take care, some editors (gedit) hide the last line even if there is a lineending. I got fooled by this already and committed a double lineending once.

It's not really important if art files have these things, but code and files edited by hand ought to IMO

Stan added a comment.Nov 14 2017, 10:05 PM

Should I manually add that line and commit a fix ?