Paths

Table of Contentst

Diffusion 0 A.D. Public Repository rP20517

Remove +1 in getPlayerTeam and areAllies of rmgen/ and -1 in the calls to that…
rP20517
Actions

Tags

None

Subscribers

Description

Remove +1 in getPlayerTeam and areAllies of rmgen/ and -1 in the calls to that following rP16100.

Details

Committed

Nov 25 2017, 1:37 AM

Parents

rP20516: Remove getTeamsArray copy from Island Stronghold (r17734) following the…

Branches

Unknown

Tags

Unknown

Build Status

Buildable 3797
Build 6582: Post-Commit Build	Jenkins

Event Timeline

elexis committed rP20517: Remove +1 in getPlayerTeam and areAllies of rmgen/ and -1 in the calls to that….Nov 25 2017, 1:37 AM

elexis mentioned this in rP16100: Fix RMS library forgotten in the previous commit..Nov 25 2017, 1:40 AM

• leper added a subscriber: • leper.Nov 25 2017, 5:47 AM

• leper added inline comments.

/ps/trunk/binaries/data/mods/public/maps/random/rmgen/library.js
388	Useless `()`.

Harbormaster completed building B3797: rP20517: Remove +1 in getPlayerTeam and areAllies of rmgen/ and -1 in the calls to that….Nov 25 2017, 8:32 AM

elexis added inline comments.Nov 25 2017, 12:02 PM

/ps/trunk/binaries/data/mods/public/maps/random/rmgen/library.js
388	Necessary parentheses. If its removed it always returns undefined due to the https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Lexical_grammar#Automatic_semicolon_insertion

mimo added a subscriber: mimo.Nov 25 2017, 12:15 PM

mimo added inline comments.

/ps/trunk/binaries/data/mods/public/maps/random/rmgen/library.js
388	not if 383 and 384 would be merged :) (which would look nicer to me)

elexis added inline comments.Nov 25 2017, 12:57 PM

/ps/trunk/binaries/data/mods/public/maps/random/rmgen/library.js
388	The intention was to reduce the length of the lines, but actually those are only 3 more spaces, so actually agree. I will consider if the `Team` property can become mandatory too, then I could remove the parentheses in the same hunk.

Changes (4)

Path

Size

ps/

trunk/

binaries/

data/

mods/

public/

maps/

random/

rmgen/

rmgen2/

rP20517

ps/trunk/binaries/data/mods/public/maps/random/rivers.js

Loading...

ps/trunk/binaries/data/mods/public/maps/random/rmgen/library.js

Loading...

ps/trunk/binaries/data/mods/public/maps/random/rmgen/player.js

Loading...

ps/trunk/binaries/data/mods/public/maps/random/rmgen2/setup.js

Loading...