Imarok Nov 27 2017, 8:47 PM
- Differential Revision
- D1052: Count Trained Cattle as resource and not as unit (And another cattle fix)
- rP20542: Wild domestic animals should stay visible in FOW.
- Build Status
Buildable 3855 Build 6707: Post-Commit Build Jenkins
See inline comment.
Secondly this says that the trac ticket is fixed, but in the trac ticket I stated
Also as pointed out by causative, calculateEconomyScore should at least get a comment that it takes the vegetarianFood into account twice.
Because this is also more a bug than a feature, even if you say that its a good bug (because it adjusts statistics in some desirable way).
It's in fact not a good, because its just coincidence how the most recent sheep balance is, that shouldn't be hardcoded in the StatisticsTracker code.
It is in fact undesirable that vegetarian food is counted twice.
The consequence should not be that meat is counted twice too.
It means that wood/metal/stone is valued half as much as food.
Gathered resources should be gathered resources.
Economy score can do more arbitrary valuing.
(Runs cmpUnitEntityIdentity.HasClass("Domestic") needlessly twice (performance))
Im not sure if this was a good idea.
It changes history, once a resource was gathered, it will remain true that the resource was gathered.
Since the economy score is also the number of resources gathered divided by 10, it equally becomes possible to reduce the score over time.