HomeWildfire Games

Change var -> let and i++ -> ++i in rmgen wall builder and demo map
AuditedrP20546

Description

Change var -> let and i++ -> ++i in rmgen wall builder and demo map

In a bid to reduce size of D900 patch.

var -> let change suggested by @elexis

Refs D900, #2944

Event Timeline

minohaka raised a concern with this commit.Nov 28 2017, 8:04 AM
minohaka added a subscriber: minohaka.

ERROR: CMapGeneratorWorker::LoadScripts: Failed to load script 'maps/random/rmgen/wall_builder.js'

ERROR: JavaScript error: maps/random/rmgen/wall_builder.js line 1022 TypeError: redeclaration of let startX @maps/random/schwarzwald.js:1:1

/ps/trunk/binaries/data/mods/public/maps/random/rmgen/wall_builder.js
1022

This was first declare on line 1004 throws an error when trying to generate any random map

This commit now has outstanding concerns.Nov 28 2017, 8:04 AM
s0600204 requested verification of this commit.Nov 28 2017, 11:23 AM

My apologies. This should now be resolved in rP20548. Can you confirm?

This commit now requires verification by auditors.Nov 28 2017, 11:23 AM
All concerns with this commit have now been addressed.Nov 28 2017, 11:50 PM