HomeWildfire Games

Allow civ specific techs with {civ}
AuditedrP20551

Description

Allow civ specific techs with {civ}

Discussed with leper

Reviewed By: bb

Trac Tickets: #4589

Differential Revision: https://code.wildfiregames.com/D1024

Event Timeline

I'd still prefer getting rid of the individual non-{civ} and non-generic techs, might need a little cleanup in a few places, or introduction of replaces: "phase_x", though probably with an array. (Though I guess not introducing the latter is a lot cleaner.

temple raised a concern with this commit.Nov 29 2017, 3:01 PM
temple added a subscriber: temple.

Cheats are broken. It says I reached City Phase but it's a lie. :)

This commit now has outstanding concerns.Nov 29 2017, 3:01 PM
mimo added a comment.Nov 29 2017, 6:11 PM

Cheat should be fixed in rP20558
Thanks for the report

temple accepted this commit.Nov 29 2017, 6:19 PM
All concerns with this commit have now been addressed.Nov 29 2017, 6:19 PM
elexis added a subscriber: elexis.

guys there is a _generic diff in Introductory_Tutorial.js, was that forgotton here? https://code.wildfiregames.com/D11#change-KB2tpKw__gBR

mimo added a comment.Dec 5 2017, 7:11 PM

guys there is a _generic diff in Introductory_Tutorial.js, was that forgotton here? https://code.wildfiregames.com/D11#change-KB2tpKw__gBR

yep, fixed in rP20592