Move undeletable tag to identity component, preparation for allowing units without health component.
Also fix a missing init from D750/rP19987
Patch By: temple
Differential Revision: https://code.wildfiregames.com/D341
Description
Description
Details
Details
- Committed
bb Dec 3 2017, 9:54 PM - Differential Revision
- D341: Move undeletable from health to identity
- Parents
- rP20572: Delete unused SpiderMonkey GarbageCollection ScriptFunctions ForceGC in the AI…
- Branches
- Unknown
- Tags
- Build Status
Buildable 3932 Build 6877: Post-Commit Build Jenkins
Event Timeline
| /ps/trunk/binaries/data/mods/public/simulation/components/SkirmishReplacer.js | ||
|---|---|---|
| 49 | Whoever wrote this piece of code forgot to support an arbitrary amount of special filters, otherwise I would have suggested [specialFilter, templateName] = templateName.split("|"); | |
| /ps/trunk/binaries/data/mods/public/simulation/components/SkirmishReplacer.js | ||
|---|---|---|
| 49 | but we look for the lastindex of | right?, so we split of all specialfilters off, thus an arbitrary amount is allowed (there is no need for listing all special filters, they just need to be splitted from the templatename) | |
| /ps/trunk/binaries/data/mods/public/simulation/components/SkirmishReplacer.js | ||
|---|---|---|
| 49 | My mistake for not checking this carefully. lastIndexOf is correct, but L49 is wrong, it should be specialFilterPos + 1. Otherwise we have a | on the front and that won't match the replacements. | |
| /ps/trunk/binaries/data/mods/public/simulation/components/SkirmishReplacer.js | ||
|---|---|---|
| 49 | then the check can be removed too right? so we leave with shorter code \0/ | |
| /ps/trunk/binaries/data/mods/public/simulation/components/SkirmishReplacer.js | ||
|---|---|---|
| 49 | right | |
| /ps/trunk/binaries/data/mods/public/simulation/components/SkirmishReplacer.js | ||
|---|---|---|
| 49 | (already have the patch) | |
Comment Actions
Also someone might want to make the regicide hero undeletable. If players want to resign, they can click on the button (we have defeat reasons in alpha 23 in the chat too). So it would help clarifying the defeat reason and prevent unintentional deletes. If you want.
Comment Actions
Probably a good idea, could prevent some accidents.
(D1019 would've fixed the defeat reason when the hero's the last (conquest critical) unit to die.)