Splitting in two commits is good if they can be considered as two independent / logically disjoint patches. The previous commit probably doesn't work on it's own on the maps changed here.
Thanks for having done this major refactoring, this reduces the maintenance cost by a lot and allows adding new wallsets easily without having to come up with magic numbers.

Harbormaster completed building B4057: rP20626: Update random maps that use rmgen wall-placement..Dec 10 2017, 8:34 AM

Noticed something somewhat late.

/ps/trunk/binaries/data/mods/public/maps/random/caledonian_meadows.js
68	`g_WallStyles.sheepSomething` would be more descriptive
/ps/trunk/binaries/data/mods/public/maps/random/danubius.js
234	good name (it could become a non-wall style with distributePointsOnCircle). Perhaps the wall-builder should be renamed to become more versatile without lying
265	maybe `g_WallStyles.danubiusFortress` so that it couldn't interfere with anything
/ps/trunk/binaries/data/mods/public/maps/random/wild_lake.js
274	(same)

elexis added an edge: D900: Remove civ-specific hardcoding in Random Map Generation Wall Placement script..Jan 9 2018, 4:39 PM

elexis added inline comments.Jan 25 2018, 12:49 AM

/ps/trunk/binaries/data/mods/public/maps/random/danubius.js
287	Template names should all be defined and grouped at the top.

elexis added inline comments.Jan 25 2018, 12:52 AM

/ps/trunk/binaries/data/mods/public/maps/random/danubius.js
287	(To be precise, the variables used by the two removed statements should be used in these two new statements too rather than replacing it with a copy of the template name)

elexis added inline comments.Jan 25 2018, 12:58 AM

/ps/trunk/binaries/data/mods/public/maps/random/danubius.js
280	This changed the gate position. If I'm not mistaken this leaves the houses in front of the gate, making it hard for gaia units to leave the fortress (sometimes impossible if there is a treasure). (This array is both the magic of the map and an intransparent mess)