Paths

Table of Contentst

Diffusion 0 A.D. Public Repository rP20657

Use Array.from intead of the spread operator (that's more readable and more…
AuditedrP20657
Actions

Tags

None

Subscribers

Description

Use Array.from intead of the spread operator (that's more readable and more performant)

Patch by elexis

Reviewed and extended by mimo

Differential Revision: https://code.wildfiregames.com/D1135

Details

Auditors

Committed

mimo	Dec 16 2017, 5:39 PM

Differential Revision

D1135: Use Array.from intead of the spread operator

Parents

rP20656: Fix three wrongly chosen variables in rP20637 / D1093, a wrong case-insensitive…

Branches

Unknown

Tags

Unknown

Build Status

Buildable 4123
Build 7251: Post-Commit Build	Jenkins

Event Timeline

mimo committed rP20657: Use Array.from intead of the spread operator (that's more readable and more….Dec 16 2017, 5:39 PM

elexis mentioned this in D1132: Use Array instead of Set in GUIInterface.entsWithAuraAndStatusBars.Dec 16 2017, 5:50 PM

elexis accepted this commit.Dec 16 2017, 5:54 PM

elexis added a subscriber: elexis.

elexis added inline comments.

/ps/trunk/binaries/data/mods/public/simulation/components/GuiInterface.js
903	(D1132 used an array instead of set in `entsWithAuraAndStatusBars` as it's only used as an array (still the ugly splice+indexOf operation to remove), didn't actually check what's faster)

All concerns with this commit have now been addressed.Dec 16 2017, 5:54 PM

Harbormaster completed building B4123: rP20657: Use Array.from intead of the spread operator (that's more readable and more….Dec 16 2017, 6:32 PM

elexis added inline comments.Dec 17 2017, 9:52 PM

/ps/trunk/binaries/data/mods/public/simulation/components/tests/test_VisionSharing.js
54	<nitpick>`TS_ASSERT_UNEVAL_EQUALS(cmpVisionSharing.shared, new Set([1]));`</nitpick>

agreed. Done in rP20661

Stan mentioned this in D2483: Gamesetup class rewrite.Dec 18 2019, 6:22 PM

Changes (4)

Path

Size

ps/

trunk/

binaries/

data/

mods/

public/

simulation/

ai/

common-api/

entitycollection.js

components/

GuiInterface.js

tests/

test_VisionSharing.js

rP20657

ps/trunk/binaries/data/mods/public/simulation/ai/common-api/entitycollection.js

Loading...

ps/trunk/binaries/data/mods/public/simulation/components/Foundation.js

Loading...

ps/trunk/binaries/data/mods/public/simulation/components/GuiInterface.js

Loading...

ps/trunk/binaries/data/mods/public/simulation/components/tests/test_VisionSharing.js

Loading...