HomeWildfire Games

Move Pack Time to parent template
AuditedrP20804

Description

Move Pack Time to parent template

Patch by Angen

Reviewed By: mimo

Differential Revision: https://code.wildfiregames.com/D1204

Details

Auditors
bb
Committed
mimoJan 8 2018, 7:04 PM
Reviewer
mimo
Differential Revision
D1204: Move Pack Time to template
Parents
rP20803: Add missing Math.sqrt in rP20793 and apply some trivial rmgen cleanup.
Branches
Unknown
Tags
Unknown
Build Status
Buildable 4386
Build 7692: Post-Commit BuildJenkins

Event Timeline

bb raised a concern with this commit.EditedJan 9 2018, 8:52 PM
bb added a subscriber: bb.

There is a rome onager too, which didn't have a pack component, but now has an incomplete one. This on a relicgame start:

ERROR: RelaxNGValidator: Validation error: units/rome_mechanical_siege_onager_unpacked:1: Expecting an element Entity, got nothing
ERROR: RelaxNGValidator: Validation error: units/rome_mechanical_siege_onager_unpacked:1: Invalid sequence in interleave
ERROR: RelaxNGValidator: Validation error: units/rome_mechanical_siege_onager_unpacked:1: Element Pack failed to validate content
ERROR: RelaxNGValidator: Validation failed for '(null)'
ERROR: Failed to validate entity template 'units/rome_mechanical_siege_onager_unpacked'
ERROR: Error in timer on entity 1, IID93, function DoAction: TypeError: cmpTemplateManager.GetTemplate(...) is undefined
  Trigger.prototype.InitCaptureTheRelic/catafalqueTemplates<@maps/scripts/CaptureTheRelic.js:5:30
  Trigger.prototype.InitCaptureTheRelic@maps/scripts/CaptureTheRelic.js:4:41
  Trigger.prototype.DoAction@simulation/components/Trigger.js:331:3
  Timer.prototype.OnUpdate@simulation/components/Timer.js:120:4
This commit now has outstanding concerns.Jan 9 2018, 8:52 PM
mimo added a comment.Jan 9 2018, 10:23 PM
In rP20804#26775, @bb wrote:

There is a rome onager too, which didn't have a pack component, but now has an incomplete one. This on a relicgame start:

ERROR: RelaxNGValidator: Validation error: units/rome_mechanical_siege_onager_unpacked:1: Expecting an element Entity, got nothing
ERROR: RelaxNGValidator: Validation error: units/rome_mechanical_siege_onager_unpacked:1: Invalid sequence in interleave
ERROR: RelaxNGValidator: Validation error: units/rome_mechanical_siege_onager_unpacked:1: Element Pack failed to validate content
ERROR: RelaxNGValidator: Validation failed for '(null)'
ERROR: Failed to validate entity template 'units/rome_mechanical_siege_onager_unpacked'
ERROR: Error in timer on entity 1, IID93, function DoAction: TypeError: cmpTemplateManager.GetTemplate(...) is undefined
  Trigger.prototype.InitCaptureTheRelic/catafalqueTemplates<@maps/scripts/CaptureTheRelic.js:5:30
  Trigger.prototype.InitCaptureTheRelic@maps/scripts/CaptureTheRelic.js:4:41
  Trigger.prototype.DoAction@simulation/components/Trigger.js:331:3
  Timer.prototype.OnUpdate@simulation/components/Timer.js:120:4

Thanks for the report, should be fixed in rP20810

bb accepted this commit.Jan 9 2018, 10:38 PM
All concerns with this commit have now been addressed.Jan 9 2018, 10:38 PM