HomeWildfire Games

Unify Gamesetup/Lobby Chat Design

Description

Unify Gamesetup/Lobby Chat Design

Patch by fpre/ffffff
Fixes: #4986
Differential Revision: https://code.wildfiregames.com/D1051

Details

Committed
ImarokJan 24 2018, 3:54 PM
Differential Revision
D1051: Unify Gamesetup/Lobby Chat Design
Parents
rP21002: Complete rP21001.
Branches
Unknown
Tags
Unknown
Build Status
Buildable 4665
Build 8115: Post-Commit Build

Event Timeline

elexis raised a concern with this commit.Jan 28 2018, 4:26 PM
elexis added a subscriber: elexis.

The concept of introducing one Stone theme button in a page that only has Red theme buttons everywhere else is as unsettling as the resulting visual appearance IMO.

This commit now has outstanding concerns.Jan 28 2018, 4:26 PM

The concept of introducing one Stone theme button in a page that only has Red theme buttons everywhere else is as unsettling as the resulting visual appearance IMO.

Hmm, true.
@ffffffff wanna fix that?

The concept of introducing one Stone theme button in a page that only has Red theme buttons everywhere else is as unsettling as the resulting visual appearance IMO.

Hmm, true.
@ffffffff wanna fix that?

y can be
like the button but mis lead here

(Not that terrible, but doesn't seem quite right either.)

Why not just use the red design instead of the stone design for the send button?

damn ima is right :D

elexis removed an auditor: elexis.Feb 26 2018, 8:10 PM

Maybe not terrible enough for a concern.

This commit no longer requires audit.Feb 26 2018, 8:10 PM