Remove the concern if you disagree with this being worthy of a concern. While the patch gave the advantage of shortening the code, every line of the patch should be different:

• Requires public mod: mods/mod/gui/common/terms.js also contains a ConfigDB_CreateValue + ConfigDB_WriteValueToFile call but can't reuse the public/ function.
• Wrong programming language: The new function has no relation to it's immediate neighbors (sound notifications and civ data) nor to these config functions that relate to a specific setting. If this function was added to JSInterface_ConfigDB.cpp, it would be related to every other neighboring function.
• Not reusable by design: In the sense of the JSInterface_ConfigDB` and #5046, the function should also be usable with other configuration namespaces. Therefore the name User should be removed from the function name and a namespace argument added.

About the repetition of config/user.cfg in the previous ConfigDB_WriteValueToFile calls, maybe it could be considered a bug, not a feature that one can call the function with different paths but the same namespace. At least it could use the default filepath if no filepath was specified.

So

saveSettingAndWriteToUserConfig("gui.splashscreen.version", Engine.GetFileMTime("gui/splashscreen/splashscreen.txt"));

were

Engine.ConfigDB_CreateAndWriteValueToFile("user", "gui.splashscreen.version", Engine.GetFileMTime("gui/splashscreen/splashscreen.txt"));