Add a couple of string manipulation functions to globalscripts.
(And use them where appropriate.)
Description
Description
Details
Details
- Auditors
temple - Committed
s0600204 Feb 2 2018, 2:37 AM - Parents
- rP21100: Remove dae file from actor folder.
- Branches
- Unknown
- Tags
- Build Status
Buildable 4793 Build 8309: Post-Commit Build Jenkins
Event Timeline
| /ps/trunk/binaries/data/mods/public/globalscripts/Templates.js | ||
|---|---|---|
| 531–539 | In light of the other two comments, it doesn't seem we need this function (at least at this point in time). | |
| /ps/trunk/binaries/data/mods/public/simulation/components/BuildRestrictions.js | ||
| 236 | Since preview merges BuildRestrictions and Identity I think we can just use templateName? (D276) | |
| /ps/trunk/binaries/data/mods/public/simulation/components/SkirmishReplacer.js | ||
| 38–39 | This isn't equivalent to the old code. (E.g. starting women on Survival of the Fittest weren't getting the undeletable filter.) let specialFilters = templateName.split("|").slice(0, -1).join("|") + "|";The old way seems nicer than this? | |
| /ps/trunk/binaries/data/mods/public/globalscripts/Templates.js | ||
|---|---|---|
| 531–539 | It's used in the template viewer (which was committed after this, thus doesn't appear in this commit). | |
| /ps/trunk/binaries/data/mods/public/simulation/components/BuildRestrictions.js | ||
| 236 | ||
| /ps/trunk/binaries/data/mods/public/simulation/components/SkirmishReplacer.js | ||
| 38–39 | Well spotted. Should be fixed in rP21537. | |