Move GetEngineInfo to Mod.[h|cpp]
Suggested by: elexis
refs rP21239
Description
Description
Details
Details
- Auditors
ffffffff - Committed
Imarok Feb 17 2018, 6:36 PM - Parents
- rP21241: Fix selection rings while garrisoning
- Branches
- Unknown
- Tags
- Build Status
Buildable 5015 Build 8634: Trigger Windows Autobuild Build 8633: Post-Commit Build Jenkins
Event Timeline
Comment Actions
Thanks
| /ps/trunk/source/ps/Mod.cpp | ||
|---|---|---|
| 134 | I wonder if we can't replace these Evals with actual object constructors. | |
| /ps/trunk/source/ps/Mod.h | ||
| 36 | I wouldn't say it's saved game data | |
| /ps/trunk/source/ps/scripting/JSInterface_Mod.cpp | ||
| 1 | 8 | |
| /ps/trunk/source/ps/scripting/JSInterface_SavedGame.cpp | ||
| 1 | 8 | |
| /ps/trunk/source/ps/scripting/JSInterface_SavedGame.h | ||
| 1 | 8 | |
| /ps/trunk/source/ps/Mod.cpp | ||
|---|---|---|
| 134 | Looks like we use this everywhere. | |
| /ps/trunk/source/ps/Mod.cpp | ||
|---|---|---|
| 134 | We should try to find the best choice when adding new code. | |
Comment Actions
lead to immersive lags in the lobby (Engine.GetEngineInfo().mods command) (only when public mod is zipped to public.zip, unzipped all fine)
to test replace Engine.GetEngineInfo().mods in lobby.js and gamesetup.js with [] so it wont be executed
will be much faster then
but i dont know why atm
Comment Actions
I guess you mean rP21301?
If it is really the cause, we could just cache the answer of Engine.GetEngineInfo() on lobby.js init.