Stop the random map generation upon quit request (Alt+F4), refs #4822.
Differential Revision: https://code.wildfiregames.com/D1304
Discussed with: Yves
Description
Description
Details
Details
- Auditors
wraitii - Committed
elexis Feb 19 2018, 4:46 PM - Differential Revision
- D1484: Fix rmgen quit / rP21264 on OS X
- Parents
- rP21263: Add the lobby button to the summary screen.
- Branches
- Unknown
- Tags
- Build Status
Buildable 5048 Build 8677: Trigger Windows Autobuild Build 8676: Post-Commit Build Jenkins
Event Timeline
Comment Actions
This basically breaks random maps on OSX with a crashing error. The reason is that the callback is called from the map worker thread, and SDL_QuitRequested calls SDL_PollEvent, and OSX crashes when a secondary thread tries to poll events.
Not sure if it's easily fixable or if we basically need to #ifdef this for OSX (as in general calling force-quit on an app kills it directly).
(edit: it only breaks random maps as I think we use JS enough that it runs a GC? thus running the callback).
Comment Actions
My mistake, I should have realized myself that pulling events of the mainthread from within a secondary thread can't be thread-safe and it was printed in the documentation. Now I know. Thanks for finding out quickly what was wrong, I had no chance to reproduce!
Should be fixed by rP21818.
Comment Actions
Indeed, as you noted this already bit us in the past so I had a pretty good idea what was wrong. Thanks for the cleanup and the patch!