HomeWildfire Games

Hero aura adjustments

Description

Hero aura adjustments

Discussed with and ideas by: Grugnas, Hannibal_Barca

Details

Committed
templeFeb 19 2018, 9:30 PM
Differential Revision
D1279: Balance changes for Alpha 23
Parents
rP21268: Only apply Roman team bonus to citizen-soldiers
Branches
Unknown
Tags
Unknown
Build Status
Buildable 5055
Build 8687: Post-Commit BuildJenkins

Event Timeline

mimo added a subscriber: mimo.Feb 19 2018, 9:54 PM
mimo added inline comments.
/ps/trunk/binaries/data/mods/public/simulation/data/auras/units/heroes/cart_hero_hamilcar_1.json
10

"All soldiers" should be changed to "Nearby soldiers"

/ps/trunk/binaries/data/mods/public/simulation/data/auras/units/heroes/sele_hero_seleucus_victor.json
12

"for nearby war elephants"

/ps/trunk/binaries/data/mods/public/simulation/data/auras/units/heroes/spart_hero_brasidas.json
12

same here

elexis added a subscriber: elexis.Feb 19 2018, 10:00 PM

Commit message could mention that it was discussed in D1279

/ps/trunk/binaries/data/mods/public/simulation/data/auras/units/heroes/athen_hero_themistocles_1.json
11

number should be updated
D904 abandoned?

temple added inline comments.Feb 19 2018, 10:21 PM
/ps/trunk/binaries/data/mods/public/simulation/data/auras/units/heroes/athen_hero_themistocles_1.json
11

The change was to the "trains batches of units faster" part so I think the string can stay.
The change here was just a temporary fix until we decide about D904 (I still don't know).

/ps/trunk/binaries/data/mods/public/simulation/data/auras/units/heroes/cart_hero_hamilcar_1.json
10

I don't disagree, but "nearby" isn't used by any heroes so far, and e.g. Hannibal uses "all" even though he has a range. Maybe a clean-up can be done after a23 so our translators aren't swamped by little changes.

mimo added inline comments.Feb 20 2018, 9:52 AM
/ps/trunk/binaries/data/mods/public/simulation/data/auras/units/heroes/cart_hero_hamilcar_1.json
10

It is not because something else is wrong that we should not fix that. And using "all" for a range aura is certainly misleading and just lying, so should be fixed.
And why waiting for after a23, we are not yet in feature freeze! then we'll have i guess 2 or 3 weeks before going to commit freeze, which will last i guess at least one week and then only we'll go to string freeze. So already preventing us to fix strings one month before string freeze looks really inefficient to me.

elexis added inline comments.Feb 20 2018, 3:47 PM
/ps/trunk/binaries/data/mods/public/simulation/data/auras/units/heroes/cart_hero_hamilcar_1.json
10

Agree with mimo. (Firstly wrong strings must be fixed either way, preferably sooner rather than later. Secondly transifex users, even on the webinterface see strings that match the previous translation sorted by similarity, so they can copy & paste the old translation and just change one or two words. A handful of strings is not much work at all. Also if one is quick with changing the strings (same day), the transifex users won't see the first version of the string.)

temple added inline comments.Feb 20 2018, 4:27 PM
/ps/trunk/binaries/data/mods/public/simulation/data/auras/units/heroes/cart_hero_hamilcar_1.json
10

Okay.