HomeWildfire Games

New Blemmye camp for Kushites

Description

New Blemmye camp for Kushites
Issue: https://github.com/0ADMods/kushites/issues/63

Details

Committed
StanFeb 19 2018, 11:35 PM
Parents
rP21274: Add Nomad checkbox for Atlas, refs #4824, #3591.
Branches
Unknown
Tags
Unknown
Build Status
Buildable 5061
Build 8694: Post-Commit BuildJenkins

Event Timeline

mimo added a subscriber: mimo.Feb 20 2018, 9:42 AM

Shouldn't this be cleaned a bit?

units/kush_camelry_javelinist should be renamed

  • either units/kush_cavalry_javelinist_merc as is done for other civs
  • or if we don't want others civ to be able to train in these camps, units/kush_cavalry_javelinist_nuba (replace nuba by the civ of these mercenaries if not nubian) as is done in the cart embassies.

and get rid of this camelry unit.

then, as this camp play the same role as the cart embassies, it should inherit from the embassy (may be we could give a better name to this parent template) rather than from the barracks. And both should have a common class (Embassy for cart and MercenaryCamp for kush which play the same role is just a way to complicate things for the ai). And i would rather use this common class as build restriction category.

Stan added a comment.Feb 20 2018, 10:42 AM

Okay I'll fix this.

mimo added a comment.Feb 20 2018, 5:18 PM

Concerning cleanings, i've also noticed that:

why does this mercenaryCamp have camel prop? that's the only building with such props, and futhermore they really look like camel traders. Every player will try to kill them and report that as a bug. Imo we should remove them.

Why do all mercenaries units be called civ_infantry_javelinist_merc_b except kushites which are named civ_infantry_merc_javelinist_b? That should be changed.

Stan added a comment.Feb 20 2018, 7:22 PM

Should I remove the goats as well ?

mimo added a comment.Feb 20 2018, 8:29 PM

I would personnaly also remove them (there are no reason to have them on the structure and none others). But i've no strong opinion for goats as there are no ambiguities while camels really look like a enemy trader and you are tempted to try and attack them.

Stan added a comment.Feb 20 2018, 8:32 PM

What if I removed one of the camels and the props on his back, so it doesn't look like a trader ?
As suggested by Sundiata a few mins ago https://wildfiregames.com/forum/index.php?/messenger/8895/&page=13

mimo added a comment.Feb 20 2018, 8:39 PM

I don't know. If you are sure players won't try to hunt them. As i said, i'd prefer to remove all of them, but have no veto against either choice.

Nescio added a subscriber: Nescio.Jan 8 2020, 12:02 PM

either units/kush_cavalry_javelinist_merc as is done for other civs

@Stan, the reason for this is not the ai, but the template names of other civs. By naming the Blemmye camel kush_cavalry_javelinist_merc*, other civs that have similarly named units (in this case only ptol) can train their cavalry javelinist mercenaries at captured Kushite camps, and vice versa; to all civs that don't have them (all except kush and ptol) those camps are useless.
Another approach is D2536, which makes Blemmye and Nuba mercenaries generic, which means everyone can train these mercenaries at captured Kushite camps.