HomeWildfire Games

Check lobby games for incompatible mods
AuditedrP21301

Description

Check lobby games for incompatible mods

Reviewed by: elexis
Fixes #3370
Differential Revision: https://code.wildfiregames.com/D931

Details

Auditors
ffffffff
elexis
Committed
ImarokFeb 21 2018, 6:27 PM
Reviewer
elexis
Differential Revision
D931: Filter lobby games by mod
Parents
rP21300: Ambush bluffs rework.
Branches
Unknown
Tags
Unknown
Build Status
Buildable 5094
Build 8737: Trigger Windows Autobuild
Build 8736: Post-Commit BuildJenkins

Event Timeline

elexis added inline comments.
/ps/trunk/binaries/data/mods/public/gui/lobby/lobby.js
1185

(Now in order for the @ffffffff a23 GUI mod to become popular, it has to include one line to exclude this messagebox. Other than that, #5053.)

ffffffff raised a concern with this commit.May 20 2018, 1:35 AM

lead to immersive lags in the lobby (Engine.GetEngineInfo().mods command) (only when public mod is zipped to public.zip, unzipped all fine)

to test replace Engine.GetEngineInfo().mods in lobby.js and gamesetup.js with [] so it wont be executed

will be much faster then
but i dont know why atm

(i hear when they take my mod fgodmod and the lobby files and some other files are in unpacked version then on files system is less lag users tell.)

This commit now has outstanding concerns.May 20 2018, 1:36 AM

lead to immersive lags in the lobby (Engine.GetEngineInfo().mods command) (only when public mod is zipped to public.zip, unzipped all fine)
to test replace Engine.GetEngineInfo().mods in lobby.js and gamesetup.js with [] so it wont be executed
will be much faster then
but i dont know why atm
(i hear when they take my mod fgodmod and the lobby files and some other files are in unpacked version then on files system is less lag users tell.)

D1512

ffffffff accepted this commit.Jun 9 2018, 7:08 PM

rP21823 i have total trust in it

All concerns with this commit have now been addressed.Jun 9 2018, 7:08 PM