HomeWildfire Games

Use a macro for creating checkboxes in the Atlas map panel (other panels code…
AuditedrP21338

Description

Use a macro for creating checkboxes in the Atlas map panel (other panels code checkboxes in a different way)

Agreed With: elexis

Event Timeline

vladislavbelov raised a concern with this commit.EditedFeb 23 2018, 10:06 PM
vladislavbelov added a subscriber: vladislavbelov.

Changes look strange, because only small pieces in few places. Why not in other places?

/ps/trunk/source/tools/atlas/AtlasUI/ScenarioEditor/Sections/Map/Map.cpp
30

It looks ugly, please, use \ to format macroses.

This commit now has outstanding concerns.Feb 23 2018, 10:06 PM
bb added a comment.Feb 23 2018, 10:20 PM

Changes look strange, because only small pieces in few places.

D1240 will add 6 more...

Why not in other places?

Where?

/ps/trunk/source/tools/atlas/AtlasUI/ScenarioEditor/Sections/Map/Map.cpp
30

Would splitting the first line work?

In rP21338#28645, @bb wrote:

Changes look strange, because only small pieces in few places.

D1240 will add 6 more...

Why not together?

Why not in other places?

Where?

Everywhere in the file with a code duplication.

Also, the nomad checkbox seems absent.

bb added inline comments.Feb 24 2018, 6:04 PM
/ps/trunk/source/tools/atlas/AtlasUI/ScenarioEditor/Sections/Map/Map.cpp
322

Nomad?

bb requested verification of this commit.Feb 24 2018, 9:22 PM
This commit now requires verification by auditors.Feb 24 2018, 9:22 PM
All concerns with this commit have now been addressed.Feb 25 2018, 6:51 PM