HomeWildfire Games

fix some maps missing VictoryConditions
AuditedrP21492

Description

fix some maps missing VictoryConditions
refs rP21475

Details

Auditors
Itms
Committed
bbMar 10 2018, 7:10 PM
Parents
rP21491: Missing file in rP21488, reported by temple, refs #5040.
Branches
Unknown
Tags
Unknown
Build Status
Buildable 5466
Build 9241: Post-Commit BuildJenkins

Event Timeline

Itms raised a concern with this commit.Mar 10 2018, 7:33 PM
Itms added a subscriber: Itms.

I am getting

JS_ParseJSON failed!
ERROR: SyntaxError: JSON.parse: unexpected non-whitespace character after JSON data at line 32 column 3 of the JSON data

in the gamesetup.

/ps/trunk/binaries/data/mods/public/maps/scenarios/Multiplayer_demo.xml
60

The victory conditions are inside the object,

],
"VictoryConditions": []
}
This commit now has outstanding concerns.Mar 10 2018, 7:33 PM
bb requested verification of this commit.Mar 10 2018, 8:40 PM

Ah thx, thought the error was not from these changes apparently not
That indentation must have fooled me, so fixed

This commit now requires verification by auditors.Mar 10 2018, 8:40 PM
Itms accepted this commit.Dec 26 2018, 10:17 AM
All concerns with this commit have now been addressed.Dec 26 2018, 10:17 AM