Diffusion 0 A.D. Public Repository rP21612

A little cleanup of the PatchRData.cpp.
AuditedrP21612
Actions

Description

A little cleanup of the PatchRData.cpp.

Details

Auditors

Silier

Committed

vladislavbelov

Mar 24 2018, 12:20 PM

Parents

rP21611: Reduce pathfinding lag on Jebel Barkal a bit by using actor palms in the city…

Branches

Unknown

Tags

Unknown

Build Status

Buildable 5680
Build 9547: Trigger Windows Autobuild
Build 9546: Post-Commit Build	Jenkins

Event Timeline

vladislavbelov committed rP21612: A little cleanup of the PatchRData.cpp..Mar 24 2018, 12:20 PM

Harbormaster completed building B5680: rP21612: A little cleanup of the PatchRData.cpp..Mar 24 2018, 1:14 PM

elexis raised a concern with this commit.Jun 22 2018, 6:50 PM

elexis added a subscriber: elexis.

elexis added inline comments.

/ps/trunk/source/renderer/PatchRData.cpp
1346	missing spaces

This commit now has outstanding concerns.Jun 22 2018, 6:50 PM

elexis added inline comments.Jun 22 2018, 6:51 PM

/ps/trunk/source/renderer/PatchRData.cpp
1415	&& on the previous line

Thanks, I'll fix it after the FF.

It was a bad example

This commit no longer requires audit.Jun 23 2018, 1:25 PM

now I found it (refraction problem)

/ps/trunk/source/renderer/PatchRData.cpp
1423	z + pz

This commit now has outstanding concerns.Jun 3 2019, 8:04 PM

vladislavbelov mentioned this in D1949: Fixes mistypes introduced in rP21612.Jun 3 2019, 9:21 PM

vladislavbelov mentioned this in rP22334: Fixes a typo introduced in rP21612 in shore calculations, found by Angen and….Jun 3 2019, 10:19 PM

vladislavbelov requested verification of this commit.Jun 3 2019, 10:27 PM

This commit now requires verification by auditors.Jun 3 2019, 10:27 PM

Fixed in rP22334

All concerns with this commit have now been addressed.Jun 3 2019, 10:28 PM

Changes (1)

Path

Size

ps/

trunk/

source/

renderer/

PatchRData.cpp

rP21612

View Options

ps/trunk/source/renderer/PatchRData.cpp