Sometime after April 14th when upgrading the ejabberd server when these commits were done, we noticed that profile lookups of offline players don't work anymore. According to @user1 who fixed it somehow on the server, it was this commit:

lobby 2018-09-27:
user1: ... did anybody notice profile lookup is fixed?
elexis: user1: i think it was rP21718 and @Dunedan pointed out that the caching is broken
user1: elexis: no this one rP21719 D1177

This commit now has outstanding concerns.Sep 30 2018, 4:17 PM

elexis added a subscriber: user1.Sep 30 2018, 4:17 PM

@user1: Do you have any more details regarding this?

@Dunedan Yes. XpartaMuPP would relay the profile lookup request with a recipient element. EcheLOn expects to see recipient included with the profile command and (strangely) parses that for the lobby.wildfiregames.com/0ad portion. When that was missing, the command would throw an exception and cause EcheLOn to send ProfileNotFound.

@user1 can you upload your patch that you have already tested on the server?

/ps/trunk/source/tools/XpartaMuPP/EcheLOn.py
685	The issue occurs here

Fixed by rP21925 and rP21926, right?

This commit now requires verification by auditors.Dec 26 2018, 10:23 AM

No, it's a code bug and these two commits didn't change the code.

There was no commit or revision proposal to the bots meanwhile (at least I don't find any in https://code.wildfiregames.com/people/revisions/53/), in particular not the one that is applied to the lobby server to address it (and we don't have an open ticket IIRC, so the concern helps not forgetting the bug).

This commit now has outstanding concerns.Dec 28 2018, 2:43 PM

Unknown Object (User) added a subscriber: Unknown Object (User).Aug 19 2024, 4:07 AM

This comment was removed by phabadmin.

phabadmin added a subscriber: phabadmin.Aug 19 2024, 9:20 AM