HomeWildfire Games

Move some utility functions from the public mod to the mod mod in preparation…

Description

Move some utility functions from the public mod to the mod mod in preparation for upcoming commit.
Small fixes and improvement while I'm at it, by temple and elexis.

Event Timeline

Itms added a comment.EditedApr 22 2018, 2:10 PM

The eol-syle:native property wasn't added to the new functions_msgbox.js somehow.

elexis added a subscriber: elexis.Apr 22 2018, 2:14 PM

Lineendings are always forgotton, better leave it out of the master commit I'll do a commit for the accumulated files

Itms added a comment.Apr 22 2018, 2:37 PM

Lineendings are always forgotton, better leave it out of the master commit I'll do a commit for the accumulated files

👌

leper added inline comments.
/ps/trunk/binaries/data/mods/mod/gui/page_msgbox.xml
8

This was not a move in the original patch.

Itms added inline comments.Apr 22 2018, 2:59 PM
/ps/trunk/binaries/data/mods/mod/gui/page_msgbox.xml
8

Ah yes I wondered as well (this wasn't a change I made on purpose, I saw it before committing this) but I figured the elements in global.xml should not be present in message boxes, even when we are in the public mod. The FPS counter, watermark and so on should be loaded in the top-level page and do not need to be loaded in the message box. You can check that even with this move and deletion, FPS counter and so on still work when opening a message box.

leper added inline comments.Apr 22 2018, 3:15 PM
/ps/trunk/binaries/data/mods/mod/gui/page_msgbox.xml
8

Interesting.