HomeWildfire Games

Use esc to close the tabs in gamesetup

Description

Use esc to close the tabs in gamesetup
string should come after release

Patch By: ffffffff
Differential Revision: https://code.wildfiregames.com/D1242

Event Timeline

elexis added a subscriber: elexis.Oct 25 2018, 3:00 PM

Use esc to close the tabs in gamesetup

One must judge whether a hotkeys can be assigned to an action if the name and description of the hotkey matches the action, not if the default keybinding of the used hotkey is the intended defult keybinding.
If the hotkey name and description mismatch the assigned action, introduce a new hotkey with the same default binding instead or update name and description of the hotkey.

cancel = Escape ; Close or cancel the current dialog box/popup
[hotkey.tab]
close = Escape ; Close the tabs

(The same problem exists with many committed and uncommitted other hotkeys.
For example the deleting savegame hotkey is reused to delete units and replays. So the hotkey action must be updated or a new hotkey added.
Another example is switching to the previous GUI page with Escape, it should be a different default key binding like Shift+Escape.)