Diffusion 0 A.D. Public Repository rP21827

Prevent the lobby gamelist from breaking entirely if a gamestanza contains an…
rP21827
Actions

Description

Prevent the lobby gamelist from breaking entirely if a gamestanza contains an empty or invalid mod version JSON string (refs rP21301).

Catch all JSON SyntaxError exceptions in JS (refs rP18534).
The C++ ParseJSON function already catches exceptions and the resulting errors can't trigger a denial of service.

Differential Revision: https://code.wildfiregames.com/D1479
Based on patch by: Imarok
Reviewed by: Imarok
Comments By: Itms

Details

Committed

elexis

May 27 2018, 3:47 PM

Reviewer

Imarok

Differential Revision

D1479: Lobby: Ignore games with no valid modentry

Parents

rP21826: Revert 21825, it violates current freezes

Branches

Unknown

Tags

Unknown

Build Status

Buildable 6162
Build 10247: Post-Commit Build	Jenkins

Event Timeline

elexis committed rP21827: Prevent the lobby gamelist from breaking entirely if a gamestanza contains an….May 27 2018, 3:47 PM

Harbormaster completed building B6162: rP21827: Prevent the lobby gamelist from breaking entirely if a gamestanza contains an….May 27 2018, 4:39 PM

I assumed it would work like this:

start lobby match.
disconnect from the lobby. lobby bot unregisters the game.
open lobby dialog.
answer with "yes" to rejoin the lobby
some player disconnected (or joined via IP)
server send ChangeGameState to the lobby bot. lobby bot displays a lobby game with all null entries?

The lobby-dialog reconnect mechanism is new in alpha 23 and would explain why this is a newly observed behavior.
One host who had such a lobby game also experienced that he disconnected from the lobby and rejoined it with the dialog.
But I could not reproduce the issue with these steps.

elexis mentioned this in D2146: gui/common: Fix ESLint code quality violations.Aug 12 2019, 4:43 PM