HomeWildfire Games

Prevent calling the JS gamestart function twice when doubleclicking on the…

Description

Prevent calling the JS gamestart function twice when doubleclicking on the "Start Game" button.

It triggered an OOS on rejoin prior to rP21836, refs #5199 and
resulted in the playernames of the current match persisting into new gamesetups, fixes #5206.

Differential Revision: https://code.wildfiregames.com/D1558
Comments By: wraitii

Event Timeline

elexis added a comment.Jun 7 2018, 2:04 PM

The third thing that this doubleclick on gamestart triggered is one or more network FSM errors à la #3199.

Could likely harden NetServer and NetClient code a bit more too. I suspect the FSM code easier to read and write when splitting that one PREGAME state into two states (gamesetup and loading).