Refactor lobby terms and conditions UI from rP21847 / D1568 to a new terms…
rP21887
Actions

Description

Refactor lobby terms and conditions UI from rP21847 / D1568 to a new terms dialog UI and reuse that for mod.io and the UserReporter, refs #5257, #5218.

Reuse all existing strings, use a FileExists hack for mod.io until the new strings are committed.
Rename prelobby/common/terms/terms.js to termslobby.js for easier distinction from common/terms.js.

Based on patch by: bb
Differential Revision: https://code.wildfiregames.com/D1602
refs https://code.wildfiregames.com/D1601
refs https://github.com/bb-bb/0ad/tree/terms
refs https://github.com/elexis1/0ad/tree/terms

Details

Committed

elexis

Sep 14 2018, 5:14 PM

Differential Revision

D1602: Extract the terms code from the prelobby to reuse it for other term accepters (userreport)

Parents

rP21886: Split UserReporter JS and XML from mainmenu code and refactor it.

Branches

Unknown

Tags

Unknown

Build Status

Buildable 6366
Build 10553: Post-Commit Build	Jenkins

Event Timeline

elexis committed rP21887: Refactor lobby terms and conditions UI from rP21847 / D1568 to a new terms….Sep 14 2018, 5:14 PM

Harbormaster completed building B6366: rP21887: Refactor lobby terms and conditions UI from rP21847 / D1568 to a new terms….Sep 14 2018, 6:11 PM

elexis mentioned this in rP21888: This file should have been moved, not copied in the previous commit rP21887….Sep 14 2018, 10:18 PM

elexis added inline comments.Sep 15 2018, 10:52 AM

/ps/trunk/binaries/data/mods/mod/gui/modmod/modmodio.js
6	(Moving the string to the destination `modio/Disclaimer.txt` didn't work, because the backslash is escaped for the `txt` extractor but not for the `JS` extractor. Hence the FileExists hack which should be removed when we introduce the `Disclaimer.txt`.)

elexis added inline comments.Sep 15 2018, 11:08 AM

/ps/trunk/binaries/data/config/default.cfg
441	(currently unused (only written to but not read from). The disclaimer acceptance persistance should not be enabled unless the 3 legal links to mod.io to be added are decided to and implemented to become accessible from the modio ui and not only in the termsdialog.)

elexis mentioned this in D1627: Support custom buttons in the termsdialog and use it for mod.io legal links and UserReporter config paths and publications link.Sep 15 2018, 1:02 PM

In D1627#65057, @Imarok wrote:

wouldn't it be better to just open the terms window when the user clicks the enable feedback button without reading the terms instead of disabling the button?

I guess you mean that: P132, would be ok for me just like the current code. Maybe ask the author or the service administrators too.

elexis mentioned this in rP21896: Mod.io Disclaimer..Oct 2 2018, 5:55 PM

elexis mentioned this in rP22665: Move manual page values back to the page itself due to a lack of that page….Aug 14 2019, 3:55 PM