HomeWildfire Games

Display lobby TLS certificate verification errors from gloox, refs #4705.
AuditedrP21901

Description

Display lobby TLS certificate verification errors from gloox, refs #4705.

Update to the most reason why TLS certificate verification fails.
Don't use translation yet..

Differential Revision: https://code.wildfiregames.com/D1620
Upstream bugreport: https://bugs.camaya.net/ticket/?id=280

Event Timeline

elexis added a comment.Oct 9 2018, 8:03 PM

*most recent reason

/ps/trunk/source/lobby/XmppClient.cpp
1076

unneeded empty string meh

elexis added a subscriber: ffffffff.Sep 9 2019, 9:27 PM
elexis added inline comments.
/ps/trunk/source/lobby/XmppClient.h
57

uninitialized member!

If the TLS handshake fails and XmppClient::onDisconnect is called without XmppClient::onTLSConnect being called, then the uninitialized value will be read from.

This can explain why it displays some random TLS certificate error strings that didn't make sense for some users which could not connect, see See https://trac.wildfiregames.com/ticket/4705#comment:45

@ffffffff

Silier raised a concern with this commit.May 20 2020, 1:52 PM
Silier added a subscriber: Silier.
Silier added inline comments.
/ps/trunk/source/lobby/XmppClient.cpp
1071

'Typo: "certifiacte" -> certificate' reported by pilino1234 on transifex

This commit now has outstanding concerns.May 20 2020, 1:52 PM
elexis added inline comments.May 20 2020, 2:41 PM
/ps/trunk/source/lobby/XmppClient.cpp
1071

Thanks. I guess we can report it upstream :P

Keep in sync with specifications.
src/gloox.h: CertNotActive = 16, /**< The certifiacte is not yet active. */

elexis added inline comments.May 21 2020, 12:14 PM
/ps/trunk/source/lobby/XmppClient.cpp
1071

(Didn't mean we should)
I read the strings in CertificateErrorToString, RegistrationResultToString, ConnectionErrorToString, StanzaErrorToString and could not find another typo, so fixing this one.

elexis requested verification of this commit.May 21 2020, 12:15 PM
This commit now requires verification by auditors.May 21 2020, 12:15 PM
Silier accepted this commit.May 21 2020, 12:58 PM

Typo fixed in rP23685

All concerns with this commit have now been addressed.May 21 2020, 12:58 PM