HomeWildfire Games

Only update the gamesetup settings panel position when it actually changes.
AuditedrP21957

Tags
None
Subscribers
Tokens
"Manufacturing Defect?" token, awarded by elexis.

Description

Only update the gamesetup settings panel position when it actually changes.
refs rP20945

Differential Revision: https://code.wildfiregames.com/D1693
Patch By: nani
Comments By: Angen, smiley

Details

Auditors
elexis
Committed
bbDec 26 2018, 11:35 PM
Differential Revision
D1693: Avoid unnecessary updates from updateSettingsPanelPosition
Parents
rP21956: New Boudicca icon by dmAthena.
Branches
Unknown
Tags
Unknown
Build Status
Buildable 6532
Build 10801: Post-Commit BuildJenkins

Event Timeline

elexis raised a concern with this commit.Jan 19 2019, 11:02 PM
elexis added a subscriber: elexis.

The panels are misaligned. Reproduce: Open the gamesetup.

This commit now has outstanding concerns.Jan 19 2019, 11:02 PM
bb requested verification of this commit.Mar 16 2019, 3:16 PM
This commit now requires verification by auditors.Mar 16 2019, 3:16 PM
elexis accepted this commit.Apr 10 2019, 5:02 PM

I didn't test, but I guess it works as expected now. (I didn't figure out whether the bugfix is the cleanest way, I suppose I can still do another concern if it was that bad.)

All concerns with this commit have now been addressed.Apr 10 2019, 5:02 PM