HomeWildfire Games

Fix some untranslated strings, fixes #5155.
AuditedrP21960

Description

Fix some untranslated strings, fixes #5155.

Patch By: Stan
Differential Revision: https://code.wildfiregames.com/D1560

Details

Auditors
elexis
Committed
ItmsDec 28 2018, 2:07 PM
Differential Revision
D1560: Untranslated strings
Parents
rP21959: [i18n] Updated POT and PO files.
Branches
Unknown
Tags
Unknown
Build Status
Buildable 6538
Build 10810: Post-Commit BuildJenkins

Event Timeline

elexis raised a concern with this commit.Dec 28 2018, 2:21 PM
elexis added a subscriber: elexis.

Sorry for the failure in rP20537 rP20541! :-/

/ps/trunk/binaries/data/mods/mod/gui/modmod/modmod.js
370

There is D1623

/ps/trunk/binaries/data/mods/public/l10n/messages.json
302

This should have been a rename, following rP20541 (not an addition)

This commit now has outstanding concerns.Dec 28 2018, 2:21 PM
Itms added a comment.Dec 28 2018, 2:29 PM

Thanks for the remarks 👍 I posted a comment on the diff I missed, and I am going to take the opportunity to go through all the resources to see if there are no other unneeded paths. I'll create a diff for my findings.

Itms requested verification of this commit.Dec 28 2018, 8:16 PM
This commit now requires verification by auditors.Dec 28 2018, 8:16 PM
elexis accepted this commit.Dec 28 2018, 8:18 PM
All concerns with this commit have now been addressed.Dec 28 2018, 8:18 PM