HomeWildfire Games

Add Coala Bear for the license header check.

Description

Add Coala Bear for the license header check.

Reviewed By: Itms
Differential Revision: https://code.wildfiregames.com/D404

Details

Committed
vladislavbelovJan 3 2019, 12:12 AM
Reviewer
Itms
Differential Revision
D404: Add Coala Bear for the license header check
Parents
rP22009: SoundGroup cleanup.
Branches
Unknown
Tags
Unknown
Build Status
Buildable 6667
Build 10980: Post-Commit BuildJenkins

Event Timeline

elexis added a subscriber: elexis.EditedJan 7 2019, 1:58 PM

Is it intended that the Vulcan marks diffs with a wrong year in the header as "build failed"? It seems more like a lint warning.

Edit: Seems to be the case that it warns only, I thought I had seen it in a revision proposal.

vladislavbelov added a comment.EditedJan 7 2019, 2:09 PM

Is it intended that the Vulcan marks diffs with a wrong year in the header as "build failed"? It seems more like a lint warning.
Edit: Seems to be the case that it warns only, I thought I had seen it in a revision proposal.

Could you attach a link to the build?

Stan added a subscriber: Stan.Dec 20 2019, 2:51 PM
/ps/trunk/build/coala/LicenseYearBear.py
41
Index: LicenseYearBear.py
===================================================================
--- LicenseYearBear.py	(revision 23262)
+++ LicenseYearBear.py	(working copy)
@@ -38,7 +38,7 @@
         modification_year = self.get_last_modification(filename)
         if not modification_year:
             return
-        license_regexp = compile('/\* Copyright \([cC]?\) ([\d]+) Wildfire Games')
+        license_regexp = compile(r'/\* Copyright \([cC]?\) ([\d]+) Wildfire Games')
 
         for line_number, line in enumerate(file):
             match = license_regexp.search(line)