HomeWildfire Games

Remove hardcoded SkyBox sizes and use the infinity sky. No we render
AuditedrP22039

Description

Remove hardcoded SkyBox sizes and use the infinity sky. No we render
the skybox at the current camera location, so that the skybox appears
indefinitely far away. Refs #3458.

Reviewed By: wraitii
Tested By: elexis, Stan
Differential Revision: https://code.wildfiregames.com/D1683

Event Timeline

Angen awarded a token.Jan 6 2019, 10:56 PM
Angen raised a concern with this commit.Jun 3 2019, 6:04 PM
Angen added a subscriber: Angen.
This comment was removed by Angen.
This commit now has outstanding concerns.Jun 3 2019, 6:04 PM
wraitii added a subscriber: wraitii.Jun 3 2019, 6:46 PM

Are you certain the problem is with this code? I remember this kind of issues, which I thought were clipping/scissoring issues, happening for quite some time.

Angen accepted this commit.Jun 3 2019, 6:51 PM
All concerns with this commit have now been addressed.Jun 3 2019, 6:51 PM
Angen added a comment.Jun 3 2019, 6:52 PM

I followed history of changes of water_high.fs and this was the first time I got water refraction issue, but looks like it is not the problem of shader as I thought