HomeWildfire Games

Health.js cleanup. Fixes Vulkan complaints

Description

Health.js cleanup. Fixes Vulkan complaints

  • Var → let
  • Simplify some lines
  • add break to

Reviewed by: @elexis
Differential Revision: https://code.wildfiregames.com/D1770

Details

Committed
StanJan 31 2019, 2:34 PM
Reviewer
elexis
Differential Revision
D1770: Fix Vulkan warnings in Health.js
Parents
rP22074: Add pig animation source files.
Branches
Unknown
Tags
Unknown
Build Status
Buildable 6868
Build 11276: Post-Commit BuildJenkins

Event Timeline

Stan added a subscriber: elexis.Jan 31 2019, 2:36 PM
elexis added inline comments.Feb 1 2019, 7:24 AM
/ps/trunk/binaries/data/mods/public/simulation/components/Health.js
111

(I missed the unneeded parentheses)

148

The whitespace here was correct (according to the coding conventions I had to commit)

282

(Perhaps we can eventually figure out some hack some day that allows designating prototype functions as private, or find some way to actually make them private / local.)

smiley added a subscriber: smiley.Feb 1 2019, 7:32 AM
smiley added inline comments.
/ps/trunk/binaries/data/mods/public/simulation/components/Health.js
282

One can always use the (imo, bad) _something convention.

Stan marked 2 inline comments as done.Feb 7 2019, 4:52 PM