HomeWildfire Games

Improve and fix checkrefs.pl, add a readme for usage, add mod support, add…

Description

Improve and fix checkrefs.pl, add a readme for usage, add mod support, add command line arguments.
Reviewed by: @Itms
Comments by: @elexis

Differential Revision: https://code.wildfiregames.com/D1381

Details

Committed
StanFeb 24 2019, 10:19 PM
Reviewer
Itms
Differential Revision
D1381: Improve and fix checkrefs.pl
Parents
rP22095: Ships update
Branches
Unknown
Tags
Unknown
Build Status
Buildable 6936
Build 11355: Post-Commit Build (macOS)Jenkins

Event Timeline

Itms added a comment.Jun 29 2019, 10:18 PM

@Stan The script always returns 0, which makes Jenkins not complain about anything. See for instance https://jenkins.wildfiregames.com/blue/rest/organizations/jenkins/pipelines/svn/runs/1085/nodes/46/log/?start=0.

The errors detected remain unnoticed because the build is marked as successful. I think this was done on purpose because of the medit_city_tile duplication false positive, but if we could fix that one, we could then make the perl script error out, and then we wouldn't miss things like the broken straps_kush_base.

Stan added a subscriber: wraitii.Jun 29 2019, 11:20 PM

I wanted to write something to detect which maps where using textures but I don't know how to parse the pmp binary with python to figure out

  1. Which texture is used the most
  2. How to replace it

As for the errors I don't kbow why @wraitii's map breaks the game. I'll look at the straps I'm not sure why I missed it.

In rP22096#34613, @Itms wrote:

@Stan The script always returns 0, which makes Jenkins not complain about anything. See for instance https://jenkins.wildfiregames.com/blue/rest/organizations/jenkins/pipelines/svn/runs/1085/nodes/46/log/?start=0.

The errors detected remain unnoticed because the build is marked as successful. I think this was done on purpose because of the medit_city_tile duplication false positive, but if we could fix that one, we could then make the perl script error out, and then we wouldn't miss things like the broken straps_kush_base.