Remove and Update some outdated tips and refactor tip displaying
Reviewed by: s0600204, Nescio, Imarok
Patch by: Angen
Refs: #4428
Differential Revision: https://code.wildfiregames.com/D1377
Remove and Update some outdated tips and refactor tip displaying
Description
Details
Event TimelineComment Actions Actually, would have been a good opportunity to move the strings from public-gui-other.pot to a new translation resource, so that strings like 2000 Food. are not in the same pot as the majority of the GUI. Too bad I didn't think of that sooner. (Though I'm not sure whether the transifex webinterface offers previous similar translations of different resources.) (Reviewed by: <committer> always seemed redundant to me. At least I would recommend everyone to not commit others work that they didn't review, even if there is someone else who reviewed it) Comment Actions I think a possible use-case of the Reviewed By is when someone made a review remotely from phabricator, like via IRC/voice chat/live (for example on conference). Comment Actions Reviewed By has the use case that one can grep it, but I was more refering to Reviewed By: <comitter>, where <comitter> is the person that committed it. Comment Actions Oh, I missed that part, sorry. I understood it incorrectly.
I absolutely agree. Comment Actions I listed myself, because I thought not listing myself leaves the impression I didn't review the patch. But you are right, committing implies a review by the committer, so listing myself is redundant. Comment Actions It would mean that, if we were to allow commits without the committer reviewing himself. We just haven't done it so far, but there were proposals to do it. |