Diffusion 0 A.D. Public Repository rP22161

Fixes
rP22161
Actions

Description

Fixes
C4458 in AtlasObjectImpl.cpp line 292 and in AtlasUI/Object.cpp:547
C4456 in MapDialog.cpp:173 and in ScenarioEditor.cpp:742

Reviewed by: @Angen
Accepted by: @Itms
Comments by: @vladislavbelov

Differential Revision: https://code.wildfiregames.com/D1741

Details

Committed

Stan	Apr 5 2019, 2:37 PM

Reviewer

Silier

Differential Revision

D1741: Fix some warning for vs2015 in Atlas

Parents

rP22160: Fix berry bushes smoothing groups,

Branches

Unknown

Tags

Unknown

Build Status

Buildable 7112
Build 11610: Trigger Windows Autobuild
Build 11609: Post-Commit Build	Jenkins

Event Timeline

Stan committed rP22161: Fixes.Apr 5 2019, 2:37 PM

Stan added subscribers: Silier, vladislavbelov, Itms.

Harbormaster completed building B7112: rP22161: Fixes.Apr 5 2019, 3:12 PM

vladislavbelov added inline comments.Apr 5 2019, 5:45 PM

/ps/trunk/source/tools/atlas/AtlasObject/AtlasObjectXML.cpp
48	Missed space.

Changes (10)

Path

Size

ps/

trunk/

source/

tools/

atlas/

AtlasObject/

AtlasUI/

CustomControls/

MapDialog/

MapDialog.cpp

ScenarioEditor/

ScenarioEditor.cpp

Sections/

Object/

Object.cpp

Object.h

rP22161

View Options

ps/trunk/source/tools/atlas/AtlasObject/AtlasObject.h

View Options

ps/trunk/source/tools/atlas/AtlasObject/AtlasObjectImpl.cpp

View Options

ps/trunk/source/tools/atlas/AtlasObject/AtlasObjectImpl.h

View Options

ps/trunk/source/tools/atlas/AtlasObject/AtlasObjectJS.cpp

View Options

ps/trunk/source/tools/atlas/AtlasObject/AtlasObjectText.cpp

View Options

ps/trunk/source/tools/atlas/AtlasObject/AtlasObjectXML.cpp

View Options

ps/trunk/source/tools/atlas/AtlasUI/CustomControls/MapDialog/MapDialog.cpp

View Options

ps/trunk/source/tools/atlas/AtlasUI/ScenarioEditor/ScenarioEditor.cpp

View Options

ps/trunk/source/tools/atlas/AtlasUI/ScenarioEditor/Sections/Object/Object.cpp

View Options

ps/trunk/source/tools/atlas/AtlasUI/ScenarioEditor/Sections/Object/Object.h

FixesrP22161Actions

Description

Details

Event Timeline

Changes (10)

rP22161

ps/trunk/source/tools/atlas/AtlasObject/AtlasObject.h

ps/trunk/source/tools/atlas/AtlasObject/AtlasObjectImpl.cpp

ps/trunk/source/tools/atlas/AtlasObject/AtlasObjectImpl.h

ps/trunk/source/tools/atlas/AtlasObject/AtlasObjectJS.cpp

ps/trunk/source/tools/atlas/AtlasObject/AtlasObjectText.cpp

ps/trunk/source/tools/atlas/AtlasObject/AtlasObjectXML.cpp

ps/trunk/source/tools/atlas/AtlasUI/CustomControls/MapDialog/MapDialog.cpp

ps/trunk/source/tools/atlas/AtlasUI/ScenarioEditor/ScenarioEditor.cpp

ps/trunk/source/tools/atlas/AtlasUI/ScenarioEditor/Sections/Object/Object.cpp

ps/trunk/source/tools/atlas/AtlasUI/ScenarioEditor/Sections/Object/Object.h

Fixes
rP22161
Actions