Diffusion 0 A.D. Public Repository rP22175

Remove useless class, test class and use boost instead of it in…
AuditedrP22175
Actions

Description

Remove useless class, test class and use boost instead of it in test_RangeManager.h. Use boost::random::uniform_real_distribution<double> instead of deprecated boost::uniform_real<> in that class as well.

Refs #5428
Reviewed by: @Angen, @vladislavbelov

Differential Revision: https://code.wildfiregames.com/D1584

Details

Auditors

Silier

Committed

Stan	Apr 9 2019, 11:50 PM

Reviewer

Silier

Differential Revision

D1821: Remove useless Random class

Parents

rP22174: Corrections in game loading quotes.

Branches

Unknown

Tags

Unknown

Build Status

Buildable 7144
Build 11653: Trigger Windows Autobuild
Build 11652: Post-Commit Build	Jenkins

Event Timeline

Stan committed rP22175: Remove useless class, test class and use boost instead of it in….Apr 9 2019, 11:50 PM

Stan added subscribers: Silier, vladislavbelov.

Stan mentioned this in D1821: Remove useless Random class.Apr 9 2019, 11:53 PM

Closed the wrong differential.

Harbormaster completed building B7144: rP22175: Remove useless class, test class and use boost instead of it in….Apr 10 2019, 12:11 AM

wrong diff link, include should be replaced, gameboy reported broken build on forum ( I wonder how Harbormaster passed, I dont have time now to test build), from his report looks that uniform_real_distribution' : is not a member of 'boost'

looking into header file
boost:: - > boost::random::

This commit now has outstanding concerns.Apr 10 2019, 6:18 AM

Will fix it asap for some reason the commit did not add all my changes... Thanks for the report.

Stan mentioned this in rP22178: Fix rP22175. Refs #5428.Apr 10 2019, 8:05 AM

Stan requested verification of this commit.Apr 10 2019, 8:40 AM

This commit now requires verification by auditors.Apr 10 2019, 8:40 AM

elexis added an edge: D1821: Remove useless Random class.Apr 10 2019, 2:23 PM

Silier accepted this commit.Apr 10 2019, 5:05 PM

All concerns with this commit have now been addressed.Apr 10 2019, 5:05 PM