Paths

Table of Contentst

Diffusion 0 A.D. Public Repository rP22182

Add ConquestCritical to structures that want it, instead of removing it from…
AuditedrP22182
Actions

Description

Add ConquestCritical to structures that want it, instead of removing it from those that don't want it.
While add it remove conquestCritical from benches/fences/tables/columns etc.

Patch By: Nescio
Differential Revision: https://code.wildfiregames.com/D1626

Details

Auditors

Itms

Provenance

bb	Authored on

Differential Revision

D1626: -ConquestCritical clear-up

Parents

rP22181: Reduce duplication in template_structure_military*

Branches

Unknown

Tags

Unknown

Build Status

Buildable 7161
Build 11674: Post-Commit Build (macOS)	Jenkins

Event Timeline

bb committed rP22182: Add ConquestCritical to structures that want it, instead of removing it from….Apr 12 2019, 5:05 PM

Harbormaster completed building B7161: rP22182: Add ConquestCritical to structures that want it, instead of removing it from….Apr 12 2019, 5:06 PM

While trying to add the nice improvements from rP22096 to Jenkins, I got this error:

Error parsing structures/spart_syssiton: Duplicate child node 'Classes' at Entity.pm line 45.

The fix looks trivial.

/ps/trunk/binaries/data/mods/public/simulation/templates/structures/spart_syssiton.xml
27	The `Classes` node is already here.

This commit now has outstanding concerns.Apr 13 2019, 12:50 AM

Nescio mentioned this in D1824: merge spart_syssiton.xml classes.Apr 13 2019, 9:41 AM

Itms mentioned this in rP22183: Fix issue in rP22182, detected by the checkrefs.pl script..Apr 13 2019, 11:22 AM

Fixed by Nescio in rP22183.

All concerns with this commit have now been addressed.Apr 13 2019, 11:28 AM

structures that want it

(Tiny grammar improvement: Neither structures nor code wants to do something, not even the authors want to do something, but actions are performed to achieve purposes. )
(-> Add ConquestCritical to structures that should have it, instead of removing it from those that should not).

Changes (31)

Path

Size

ps/

trunk/

binaries/

data/

mods/

public/

simulation/

templates/

other/

structures/

kush_pyramid_large.xml

kush_pyramid_small.xml

maur_palace.xml

maur_pillar_ashoka.xml

template_structure.xml

template_structure_civic.xml

template_structure_defensive_tower.xml

template_structure_defensive_wall.xml

template_structure_defensive_wall_tower.xml

template_structure_economic.xml

template_structure_military.xml

template_structure_resource.xml

template_structure_special_library.xml

Add ConquestCritical to structures that want it, instead of removing it from…AuditedrP22182Actions

Description

Details

Event Timeline

Changes (31)

rP22182

ps/trunk/binaries/data/mods/public/simulation/templates/other/obelisk.xml

ps/trunk/binaries/data/mods/public/simulation/templates/structures/athen_gymnasion.xml

ps/trunk/binaries/data/mods/public/simulation/templates/structures/athen_prytaneion.xml

ps/trunk/binaries/data/mods/public/simulation/templates/structures/cart_super_dock.xml

ps/trunk/binaries/data/mods/public/simulation/templates/structures/iber_monument.xml

ps/trunk/binaries/data/mods/public/simulation/templates/structures/kush_pyramid.xml

ps/trunk/binaries/data/mods/public/simulation/templates/structures/kush_pyramid_large.xml

ps/trunk/binaries/data/mods/public/simulation/templates/structures/kush_pyramid_small.xml

ps/trunk/binaries/data/mods/public/simulation/templates/structures/maur_palace.xml

ps/trunk/binaries/data/mods/public/simulation/templates/structures/maur_pillar_ashoka.xml

ps/trunk/binaries/data/mods/public/simulation/templates/structures/pers_apadana.xml

ps/trunk/binaries/data/mods/public/simulation/templates/structures/pers_hall.xml

ps/trunk/binaries/data/mods/public/simulation/templates/structures/pers_ishtar_gate.xml

ps/trunk/binaries/data/mods/public/simulation/templates/structures/pers_tacara.xml

ps/trunk/binaries/data/mods/public/simulation/templates/structures/ptol_lighthouse.xml

ps/trunk/binaries/data/mods/public/simulation/templates/structures/rome_arch.xml

ps/trunk/binaries/data/mods/public/simulation/templates/structures/rome_army_camp.xml

ps/trunk/binaries/data/mods/public/simulation/templates/structures/spart_gerousia.xml

ps/trunk/binaries/data/mods/public/simulation/templates/structures/spart_syssiton.xml

ps/trunk/binaries/data/mods/public/simulation/templates/template_structure.xml

ps/trunk/binaries/data/mods/public/simulation/templates/template_structure_civic.xml

ps/trunk/binaries/data/mods/public/simulation/templates/template_structure_defensive_tower.xml

ps/trunk/binaries/data/mods/public/simulation/templates/template_structure_defensive_wall.xml

ps/trunk/binaries/data/mods/public/simulation/templates/template_structure_defensive_wall_tower.xml

ps/trunk/binaries/data/mods/public/simulation/templates/template_structure_economic.xml

ps/trunk/binaries/data/mods/public/simulation/templates/template_structure_military.xml

ps/trunk/binaries/data/mods/public/simulation/templates/template_structure_resource.xml

ps/trunk/binaries/data/mods/public/simulation/templates/template_structure_special_library.xml

ps/trunk/binaries/data/mods/public/simulation/templates/template_structure_special_rotarymill.xml

ps/trunk/binaries/data/mods/public/simulation/templates/template_structure_special_theatron.xml

ps/trunk/binaries/data/mods/public/simulation/templates/template_structure_wonder.xml

Add ConquestCritical to structures that want it, instead of removing it from…
AuditedrP22182
Actions