HomeWildfire Games

Actually add the test file for rP22205.
AuditedrP22207

Description

Actually add the test file for rP22205.

Event Timeline

vladislavbelov added inline comments.
/ps/trunk/source/simulation2/components/tests/test_HierPathfinder.h
95

There're compilation errors for the map assignments on VS2013. @Itms do we plan to drop the 2013 one?

error C2593: 'operator =' is ambiguous (..\..\..\source\simulation2\components\tests\test_HierPathfinder.cpp)

Stan added a subscriber: Stan.Apr 23 2019, 8:11 AM
Stan added inline comments.
/ps/trunk/source/simulation2/components/tests/test_HierPathfinder.h
95

Yes it's planned. There is a ticket for it.

https://trac.wildfiregames.com/ticket/5379

Itms added a comment.Apr 23 2019, 8:22 AM

It's indeed planned (but not effective yet so we should fix this or we won't have autobuild). The actual measure that I should take is to put into place patch testing on the Windows autobuilder. Will post a related message on the forums later today.

Annoying... Can anyone raise a concern? I'm not sure I'll have time to fix it today/tonight - also don't have VS13. I'll have time tomorrow if needed.

Itms raised a concern with this commit.Apr 23 2019, 8:58 AM
This commit now has outstanding concerns.Apr 23 2019, 8:58 AM
Stan added inline comments.Apr 23 2019, 9:50 AM
/ps/trunk/source/simulation2/components/tests/test_HierPathfinder.h
95

I think you can just replace that by

pathClassMask = map <std::string, pass_class_t>{
	{ "1", 1 },
	{ "2", 2 },
};
nonPathClassMask = map <std::string, pass_class_t>{
	{ "3", 4 }
};

According to: http://www.cplusplus.com/forum/general/123326/

Any chance you can test that?

Stan added a comment.Apr 23 2019, 10:51 AM

Will try. Finally understood why simply installing buildtools doesn't work. They only included C# and VB.net. So I need to install VS2013

Itms added a comment.Apr 23 2019, 11:01 AM

I'm at work so I only have Linux, but if Stan doesn't get around to it I can test tonight.

Well whoever gets to test it first commits the fix I'd say 👍

Any chance you can test that?

I can test on VS2013.

Any chance you can test that?

I can test on VS2013.

You can test the above patch :) D1845

Itms accepted this commit.Apr 23 2019, 10:56 PM
All concerns with this commit have now been addressed.Apr 23 2019, 10:56 PM