Actually add the test file for rP22205.
Description
Description
Details
Details
- Auditors
Itms - Committed
wraitii Apr 22 2019, 2:44 PM - Parents
- rP22206: Add a few assertions to pathfinder tests, fix the disabled tests.
- Branches
- Unknown
- Tags
- Build Status
Buildable 7246 Build 11812: Trigger Windows Autobuild Build 11811: Post-Commit Build Jenkins
Event Timeline
| /ps/trunk/source/simulation2/components/tests/test_HierPathfinder.h | ||
|---|---|---|
| 95 | Yes it's planned. There is a ticket for it. | |
Comment Actions
It's indeed planned (but not effective yet so we should fix this or we won't have autobuild). The actual measure that I should take is to put into place patch testing on the Windows autobuilder. Will post a related message on the forums later today.
Comment Actions
Annoying... Can anyone raise a concern? I'm not sure I'll have time to fix it today/tonight - also don't have VS13. I'll have time tomorrow if needed.
| /ps/trunk/source/simulation2/components/tests/test_HierPathfinder.h | ||
|---|---|---|
| 95 | I think you can just replace that by pathClassMask = map <std::string, pass_class_t>{
{ "1", 1 },
{ "2", 2 },
};
nonPathClassMask = map <std::string, pass_class_t>{
{ "3", 4 }
};According to: http://www.cplusplus.com/forum/general/123326/ | |
Comment Actions
Will try. Finally understood why simply installing buildtools doesn't work. They only included C# and VB.net. So I need to install VS2013
Comment Actions
I'm at work so I only have Linux, but if Stan doesn't get around to it I can test tonight.
Comment Actions
Can't compile this test file on gcc 10 and clang 10, see #5756. (I assume it is this commit since it introduced the test and it wasn't changed much later, but I didn't compare the function signatures.)