Fix D1491 which introduced an ENSURE that should not have been there.
Reported by wowgetoffyourcellphone.
Description
Description
Details
Details
- Auditors
Itms - Committed
wraitii Apr 25 2019, 9:08 AM - Parents
- rP22224: [Windows] Automated build.
- Branches
- Unknown
- Tags
- Build Status
Buildable 7287 Build 11869: Trigger Windows Autobuild Build 11868: Post-Commit Build Jenkins
Event Timeline
Comment Actions
This is removing state.jpc = m_JumpPointCache[passClass].get(); when it != m_JumpPointCache.end(), no?
Don't hesitate to open a diff even for hot fixes. For instance that could allow Justus to test it, since he can reproduce the issue. And one would have noticed what I saw.
Comment Actions
It is indeed... We don't use the jpc at the moment so this doesn't crash, but it should be fixed.
Don't hesitate to open a diff even for hot fixes. For instance that could allow Justus to test it, since he can reproduce the issue. And one would have noticed what I saw.
OK, I'll do next time. Note that I could also reproduce the issue this morning, since this was crashing 100% of the time.
(also I'll probably add a way to run a quick non-visual autostart for a fixed # of turns and add that to my git test alias to make sure I don't miss actually starting a game)