HomeWildfire Games
Diffusion 0 A.D. Public Repository rP22275

Fix move speed not correctly reset when chasing a unit
rP22275
Actions

Description

Fix move speed not correctly reset when chasing a unit

rP22197 had an issue where the move speed was not correctly reset after chasing a unit.

Reported By: Angen
Reviewed By: Angen

Differential Revision: https://code.wildfiregames.com/D1861

Details

Committed
wraitiiMay 11 2019, 2:23 PM
Reviewer
Silier
Differential Revision
D1861: Fix move speed not correctly reset when chasing a unit
Parents
rP22274: Replace all shields by the new shields in the gaul barracks.xml
Branches
Unknown
Tags
Unknown
Build Status
Buildable 7434
Build 12096: Post-Commit BuildJenkins

Event Timeline

wraitii committed rP22275: Fix move speed not correctly reset when chasing a unit.May 11 2019, 2:23 PM
Harbormaster completed building B7434: rP22275: Fix move speed not correctly reset when chasing a unit.May 11 2019, 2:58 PM
Freagarach added a subscriber: Freagarach.May 13 2019, 9:15 PM
Freagarach added inline comments.
/ps/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
2040

this.ResetSpeedMultiplier(); ?

Silier added a subscriber: Silier.May 13 2019, 9:17 PM
Silier added inline comments.
/ps/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
2040

yes, why ?

Freagarach removed subscribers: Silier, Freagarach.May 13 2019, 9:20 PM
Freagarach added inline comments.
/ps/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
2040

I'm sorry, I need to be more verbose.
I was testing D1871 and I got an error stating that this.ResetMoveSpeed() is not a function, so I checked UnitAI.js and I think you meant this.ResetSpeedMultiplier(); ?

Freagarach added a comment.May 13 2019, 9:21 PM

Sorry for the removed subscription, I don't know what happened,,,

Freagarach added subscribers: Silier, Freagarach.May 13 2019, 9:21 PM
Silier added inline comments.May 13 2019, 9:23 PM
/ps/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
2040

you need to rebuild game, there have been c++ changes, but yes @wraitii missed this line in another patch after this, thank you

Freagarach removed a subscriber: Freagarach.May 13 2019, 9:29 PM
Freagarach added inline comments.
/ps/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
2040

I already did rebuild it, but I missed rP22277 changed UnitAI.js as well, thanks for pointing out! Glad to be of service.

wraitii mentioned this in rP22281: Fix ResetMoveSpeed rename missed in rP22277, introduced by rP22275..May 13 2019, 9:41 PM

Changes (1)

PathSize
ps/
trunk/
binaries/
data/
mods/
public/
simulation/
components/

rP22275

View Options

ps/trunk/binaries/data/mods/public/simulation/components/UnitAI.js

Loading...
Wildfire Games ยท Phabricator