HomeWildfire Games

UnitMotion - improve variable names and reuse a duplicated function (cleanup…
AuditedrP22277

Description

UnitMotion - improve variable names and reuse a duplicated function (cleanup rP22197)

This:

  • cleans up a code duplication and clarifies the intent.
  • reorders things around for clarity
  • improves variable names.

Commented By: elexis

Differential Revision: https://code.wildfiregames.com/D1840

Event Timeline

Silier added inline comments.
/ps/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
2040

@Freagarach reported this is missed

Silier raised a concern with this commit.May 13 2019, 9:24 PM
This commit now has outstanding concerns.May 13 2019, 9:24 PM
wraitii marked an inline comment as done.May 13 2019, 9:41 PM

Indeed, missed that conflict between the two revisions.

Silier accepted this commit.May 13 2019, 9:50 PM
All concerns with this commit have now been addressed.May 13 2019, 9:50 PM