HomeWildfire Games

Add unit motion integration test map
Needs VerificationrP22296

Description

Add unit motion integration test map

This uses trigger to create some scientific test cases for unit motion (the whole unitAI->Motion->Pathfinders stack)

Differential Revision: https://code.wildfiregames.com/D1892

Details

Auditors
elexis
Committed
wraitiiMay 25 2019, 12:26 PM
Differential Revision
D1892: Add unit motion integration test map
Parents
rP22295: Target build version explicitly for Xcode
Branches
Unknown
Tags
Unknown
Build Status
Buildable 7575
Build 12348: Post-Commit BuildJenkins

Event Timeline

elexis added a subscriber: elexis.Jun 24 2019, 3:26 PM

unit_motion_integration_test.js

trigger scripts usually contain the name triggers:

./random/elephantine_triggers.js
./random/extinct_volcano_triggers.js
./random/survivalofthefittest_triggers.js
./random/wall_demo_triggers.js
./random/danubius_triggers.js
./random/jebel_barkal_triggers.js
./random/polar_sea_triggers.js

Except for scenario folders:

./unit_motion_integration_test.js
./treasure_islands.js
./Units_demo.js
./Triggers_demo.js
./Cinema_Demo.js

(But I technically don't want to spawn another rename clean thing now)

Test doesn't seem that off, perhaps some more enemy units would be reasonable to interact with those existing ones. Depends on what ones to test, anyhow.

/ps/trunk/binaries/data/mods/public/maps/scenarios/unit_motion_integration_test.js
4

(Would be nice to have passed in some ctor)

59

prototype might have been nice

62

Vector2D

63
var experiments = {
       "property1": {
               "function1": () => {
                      ....
                }
        } 
};

While the additional nesting is meh, it doesn't add any new scopes and it actually removes the possibility to add unrelated functions or globals in between (removes the possibility for fragmentation).

Actually it seems to be more be an array of test cases, so it should actually become/should have been an array.

/ps/trunk/binaries/data/mods/public/maps/scenarios/unit_motion_integration_test.xml
36

good tags / description / name

elexis raised a concern with this commit.Aug 2 2019, 2:15 AM

Checkrefs script detected this:

/public/maps/scenarios/unit_motion_integration_test.xml:0: Relax-NG validity error : Element Scenario failed to validate content

(https://jenkins.wildfiregames.com/job/docker-svn/124/consoleFull)

I couldn't find quickly what it wants, I assume it misses some element.

This commit now has outstanding concerns.Aug 2 2019, 2:15 AM
wraitii requested verification of this commit.Aug 12 2019, 10:06 AM

Not sure what was missing or too much, but it's fixed now.

This commit now requires verification by auditors.Aug 12 2019, 10:06 AM